You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2014/04/04 22:00:10 UTC

[Bug 56287] mod_proxy_html deletes wrong data from HTML when meta http-equiv tag specifies Content-Type behind other meta http-equiv tag

https://issues.apache.org/bugzilla/show_bug.cgi?id=56287

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk,
                   |                            |PatchAvailable

--- Comment #2 from Christophe JAILLET <ch...@wanadoo.fr> ---
Thanks for the report.

I confirm your point and I have commited it as r1584878.
It can only be triggered if ProxyHTMLMeta is set, which is not the default.


However a few other issues puzzle me:

   - what if several "Content-Type" are found ? 
     With current code, only the latest will be taken into account

   - line 675:
          if (*p != '=')
              continue;
    Really ? Shouldn't we break instead ?
    Continue will go back to line 671 and we will perform a p +=7 which could
go past the end of the buffer

   - line 680:
     Shouldn't we also check for *q in case only one delimiter ('\'' or '"') is
present. Without it, we could scan past the end of the buffer

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org