You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Chamikara Madhusanka Jayalath (Jira)" <ji...@apache.org> on 2020/02/15 02:25:00 UTC

[jira] [Resolved] (BEAM-9215) FileBesedSink may suppress exceptions during close

     [ https://issues.apache.org/jira/browse/BEAM-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chamikara Madhusanka Jayalath resolved BEAM-9215.
-------------------------------------------------
    Fix Version/s: 2.20.0
       Resolution: Fixed

> FileBesedSink may suppress exceptions during close
> --------------------------------------------------
>
>                 Key: BEAM-9215
>                 URL: https://issues.apache.org/jira/browse/BEAM-9215
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Chamikara Madhusanka Jayalath
>            Priority: Major
>             Fix For: 2.20.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> We invoke closeChannelAndThrow() here when there's an exception when closing.
> [https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java#L961]
>  
> But we suppress the exception if second close() trivially succeeds for some reason. We should raise the exception nevertheless allowing the runner to retry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)