You are viewing a plain text version of this content. The canonical link for it is here.

Posted to user@struts.apache.org by Dipak Tank <di...@gmail.com> on 2024/12/26 10:07:07 UTC

Fwd: Struts 7.0.0 - JSP rendering is taking 3X time compare to struts 6.3.0.2

Hi

After upgrading to version 7.0.0, the JSP rendering time has significantly
increased from around 500ms to approximately 1.5 seconds. Upon further
investigation, it was discovered that the increase in time is primarily due
to Ognl.getValue taking longer than it did in the previous version.

Datadog Profiling screenshot:

[image: image.png]

Sample JSP & Java Code as below:

[image: image.png]

We have added following constant in struts.xml

<constant name="struts.chaining.copyErrors" value="true" />
<constant name="struts.chaining.copyMessages" value="true" />
<constant name="struts.ui.checkbox.submitUnchecked" value="true"/>
<constant name="struts.ognl.expressionMaxLength" value=""/>
<constant name="struts.parameters.requireAnnotations" value="false"/>
<constant name="struts.allowlist.enable" value="false"/>
<constant name="struts.mapper.alwaysSelectFullNamespace" value="false"/>
<constant name="struts.actionConfig.fallbackToEmptyNamespace" value="true"/>

Can you please help with this ?

-- 
Thanks,
Dipak Tank

Re: Struts 7.0.0 - JSP rendering is taking 3X time compare to struts 6.3.0.2

Posted by Dipak Tank <di...@gmail.com>.

Thanks for the prompt reply.

Let me prepare it.

On Thu, Dec 26, 2024 at 5:36 PM Lukasz Lenart <lu...@apache.org>
wrote:

> Could you prepare a sample app instead of sending your Java & JSP code? I
> already tried to reproduce your problem yet using Struts tags and
> everything is perfectly fine. Also why do you use <c:forEach/> instead of
> <s:iterator/>?
>
>
> Cheers
> Lukasz
>
> czw., 26 gru 2024 o 11:08 Dipak Tank <di...@gmail.com> napisał(a):
>
> >
> >
> > Hi
> >
> > After upgrading to version 7.0.0, the JSP rendering time has
> significantly
> > increased from around 500ms to approximately 1.5 seconds. Upon further
> > investigation, it was discovered that the increase in time is primarily
> due
> > to Ognl.getValue taking longer than it did in the previous version.
> >
> > Datadog Profiling screenshot:
> >
> > [image: image.png]
> >
> > Sample JSP & Java Code as below:
> >
> > [image: image.png]
> >
> > We have added following constant in struts.xml
> >
> > <constant name="struts.chaining.copyErrors" value="true" />
> > <constant name="struts.chaining.copyMessages" value="true" />
> > <constant name="struts.ui.checkbox.submitUnchecked" value="true"/>
> > <constant name="struts.ognl.expressionMaxLength" value=""/>
> > <constant name="struts.parameters.requireAnnotations" value="false"/>
> > <constant name="struts.allowlist.enable" value="false"/>
> > <constant name="struts.mapper.alwaysSelectFullNamespace" value="false"/>
> > <constant name="struts.actionConfig.fallbackToEmptyNamespace"
> > value="true"/>
> >
> > Can you please help with this ?
> >
> > --
> > Thanks,
> > Dipak Tank
> >
> >
>


-- 
Thanks,
Dipak Tank

Re: Struts 7.0.0 - JSP rendering is taking 3X time compare to struts 6.3.0.2

Posted by Lukasz Lenart <lu...@apache.org>.

Could you prepare a sample app instead of sending your Java & JSP code? I
already tried to reproduce your problem yet using Struts tags and
everything is perfectly fine. Also why do you use <c:forEach/> instead of
<s:iterator/>?


Cheers
Lukasz

czw., 26 gru 2024 o 11:08 Dipak Tank <di...@gmail.com> napisał(a):

>
>
> Hi
>
> After upgrading to version 7.0.0, the JSP rendering time has significantly
> increased from around 500ms to approximately 1.5 seconds. Upon further
> investigation, it was discovered that the increase in time is primarily due
> to Ognl.getValue taking longer than it did in the previous version.
>
> Datadog Profiling screenshot:
>
> [image: image.png]
>
> Sample JSP & Java Code as below:
>
> [image: image.png]
>
> We have added following constant in struts.xml
>
> <constant name="struts.chaining.copyErrors" value="true" />
> <constant name="struts.chaining.copyMessages" value="true" />
> <constant name="struts.ui.checkbox.submitUnchecked" value="true"/>
> <constant name="struts.ognl.expressionMaxLength" value=""/>
> <constant name="struts.parameters.requireAnnotations" value="false"/>
> <constant name="struts.allowlist.enable" value="false"/>
> <constant name="struts.mapper.alwaysSelectFullNamespace" value="false"/>
> <constant name="struts.actionConfig.fallbackToEmptyNamespace"
> value="true"/>
>
> Can you please help with this ?
>
> --
> Thanks,
> Dipak Tank
>
>