[GitHub] [skywalking-banyandb] hanahmily commented on pull request #257: [OAP Integration] Register missing TopN registry service

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily commented on PR #257:
URL: https://github.com/apache/skywalking-banyandb/pull/257#issuecomment-1455274632

   
   > ### How can we serialize `seriesID` of the original measure
   > The current protocol for `seriesID` in the response is `string` as `name` field. In order to deserialize it properly, we need a more sophisticated design.
   >
   
   
   A string name is not appropriate for now.
   
   An array wraps `model.v1.Tag` seems better than a sterilized string. The key of a tag could be from the source measure's schema.
   
   Here is my suggestion for this API:
   
   ```
   message Item {
       repeated model.v1.Tag entity = 1;
       model.v1.FieldValue value = 2;
     }
   ```
   
   > I totally disagree with this design which would mix a nested filter for source measure with options of `TopN` streaming operator. We may add `disableNullGroup` to the `TopNAggregation` schema.
   > 
   
   Our nested filter's implementation is based on the query processor. That's why we push https://github.com/apache/skywalking/issues/9770 to the streaming framework.
   
   Mixing them up is our long-term target. Finally, banyandb should provide a SQL variant to filter data in the streaming flow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org