You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/05/12 11:13:18 UTC

[GitHub] flink pull request #5997: [FLINK-9339] Accumulators are not UI accessible ru...

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5997

    [FLINK-9339] Accumulators are not UI accessible running in FLIP-6 mode

    ## What is the purpose of the change
    
    *This pull request fixed a issue : accumulators are not UI accessible running in FLIP-6 mode*
    
    
    ## Brief change log
    
      - *fixed header and handler error mapping*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-9339

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5997.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5997
    
----
commit 0b25eb681f19bc1a3b031290d25a3b6eaec962ec
Author: yanghua <ya...@...>
Date:   2018-05-12T11:10:54Z

    [FLINK-9339] Accumulators are not UI accessible running in FLIP-6 mode

----


---

[GitHub] flink issue #5997: [FLINK-9339] Accumulators are not UI accessible running i...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5997
  
    we can do it in this issue.


---

[GitHub] flink issue #5997: [FLINK-9339] Accumulators are not UI accessible running i...

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5997
  
    @zentol you mean change all places in this PR?  current change can fix the issue, for others, I think in a new issue we could do the refactor. what's your idea? 
    if you agree this suggestion, I could create a new refactor issue. if not I will change all the places.


---

[GitHub] flink pull request #5997: [FLINK-9339] Accumulators are not UI accessible ru...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5997


---

[GitHub] flink issue #5997: [FLINK-9339] Accumulators are not UI accessible running i...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5997
  
    This does fix the issue, but I'd like to extend this a bit. The root issue is that we're registering the handler for an arbitrary header, which is ridiculously error-prone.
    
    So i propose changing all instances of
    `handlers.add(Tuple2.of(<arbitrary_headers>, <handler>));`
    to 
    `handlers.add(Tuple2.of(<handler>.getMessageHeaders(), <handler>));`


---

[GitHub] flink issue #5997: [FLINK-9339] Accumulators are not UI accessible running i...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5997
  
    merging.


---

[GitHub] flink issue #5997: [FLINK-9339] Accumulators are not UI accessible running i...

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5997
  
    cc @zentol 


---

[GitHub] flink issue #5997: [FLINK-9339] Accumulators are not UI accessible running i...

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5997
  
    cc @zentol 


---