You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/17 08:54:55 UTC
[GitHub] [apisix-dashboard] EnableAsync opened a new issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
EnableAsync opened a new issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [ ] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
___
### Question
- What do you want to know?
I can directly delete the upstream used by route in dashboard.
Is this expected behaviour?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj edited a comment on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729333405
Yes, I think upstream can be deleted directly, and 503 can be used when the route cannot find upstream.
In other systems, such as k8s, this way is more respected.
The `propagationPolicy` is for GC, the scenario is to delete the `deployment`, which needs to be cascaded to delete replicasets and pods. You should not refer to this feature, because deployment, replicaset, and pod are inherited, they are different from upstream and route binding.
In APISIX, the relationship between the `route` and `upstream` can refer to the `service` and `pod` in k8s. They are the selection relationship of the selector label. We can indeed delete all pods, but the `service` is not affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] EnableAsync commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
EnableAsync commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729317388
> > > > * I can directly delete the upstream used by route in dashboard.
> > > > Is this expected behaviour?
> > >
> > >
> > > Yes, even if the upstream object is used in the route, we are allowed to delete it.
> > > if the user is using the dashboard, we can show a warning message for confirming.
> >
> >
> > Yes, we could allow the deletion, which is like what k8s does.
>
> ok then @EnableAsync what do you think?
I found that k8s has a parameter called "propagationPolicy" to control whether dependencies are automatically deleted or not[1].
I think it is possible to add a parameter like this to control whether or not dependencies can be removed.
[1] https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#controlling-how-the-garbage-collector-deletes-dependents
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-728970070
> * I can directly delete the upstream used by route in dashboard.
> Is this expected behaviour?
Yes, even if the upstream object is used in the route, we are allowed to delete it.
if the user is using the dashboard, we can show a warning message for confirming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-728810056
No, and this would be fixed in 2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-728971470
@nic-chen @gxthrj Please confirm that what I said above is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] EnableAsync closed issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
EnableAsync closed issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729333405
Yes, I think upstream can be deleted directly, and 503 can be used when the route cannot find upstream.
In other systems, such as k8s, this way is more respected.
The `propagationPolicy` is for GC, the scenario is to delete the `deployment`, which needs to be cascaded to delete replicasets and pods. You should not refer to this feature, because deployment, replicaset, and pod are inherited, they are different from upstream and route binding.
In APISIX, the relationship between the `route` and `upstream` can refer to the `service` and `pod` in k8s. They are the selection relationship of the selector label. We can indeed delete all pods, but the `service` is not affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729018389
> some error will appear IMO
yes, we know. that is acceptable.
The consumer of the API may be third-party platforms.
We allow to create Route (with Upstream object bound) first, and then create Upstream object.
Reduce the complexity of third-party platforms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729034859
> > > * I can directly delete the upstream used by route in dashboard.
> > > Is this expected behaviour?
> >
> >
> > Yes, even if the upstream object is used in the route, we are allowed to delete it.
> > if the user is using the dashboard, we can show a warning message for confirming.
>
> Yes, we could allow the deletion, which is like what k8s does.
ok then @EnableAsync what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-728997143
> > * I can directly delete the upstream used by route in dashboard.
> > Is this expected behaviour?
>
> Yes, even if the upstream object is used in the route, we are allowed to delete it.
>
> if the user is using the dashboard, we can show a warning message for confirming.
Yes, we could allow the deletion, which is like what k8s does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #819:
URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729001610
🤔 some error will appear IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org