Re: [PR] Fix(manual_compact):fix replica lose manual compact finished status after replica migrate bug [incubator-pegasus]

["ninsmiracle (via GitHub)" <gi...@apache.org>]

ninsmiracle commented on PR #1666:
URL: https://github.com/apache/incubator-pegasus/pull/1666#issuecomment-2011633904

   > pegasus_manual_compact_service::check_manual_compact_state
   
     Yes, `pegasus_manual_compact_service::check_manual_compact_state()` will prevent compaction log doing with this replica util next day. 
     So, if we have the parameter `last_finish_time_ms`, `pegasus_manual_compact_service::query_compact_status` will response the caller that 'this replica is FINISH manual compaction'.
     In other words, I do not think we should transfer the `status`,just need tell the caller when it send a query request. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org