You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2020/09/01 18:15:17 UTC

[GitHub] [maven-archiver] mabrarov edited a comment on pull request #10: [MSHARED-955] make parseOutputTimestamp static

mabrarov edited a comment on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685043977


   To be honest implementation of `parseOutputTimestamp` looks wrong because it doesn't parse optional time zone. This causes issues with `project.build.outputTimestamp` maven property having values like `2020-05-01T12:12:12Z`. It's a separate issue but may be we could combine changes into a single pull request.
   
   It looks I was wrong. Deleting this comment to not spoil this PR discussion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org