You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2026/05/14 23:03:21 UTC

Re: [PR] feat: show MiB unit label next to size-based admin settings inputs [texera]

codecov-commenter commented on PR #5066:
URL: https://github.com/apache/texera/pull/5066#issuecomment-4455449194

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5066?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `80.00000%` with `2 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 42.85%. Comparing base ([`7bb102e`](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48327f7`](https://app.codecov.io/gh/apache/texera/commit/48327f77b60ef301b1bd5e7cbc97361d49999c0d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/5066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...onent/admin/settings/admin-settings.component.html](https://app.codecov.io/gh/apache/texera/pull/5066?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fdashboard%2Fcomponent%2Fadmin%2Fsettings%2Fadmin-settings.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9kYXNoYm9hcmQvY29tcG9uZW50L2FkbWluL3NldHRpbmdzL2FkbWluLXNldHRpbmdzLmNvbXBvbmVudC5odG1s) | 80.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/5066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #5066   +/-   ##
   =========================================
     Coverage     42.85%   42.85%           
     Complexity     2207     2207           
   =========================================
     Files          1045     1045           
     Lines         40146    40148    +2     
     Branches       4240     4240           
   =========================================
   + Hits          17203    17205    +2     
     Misses        21878    21878           
     Partials       1065     1065           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.72% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.74% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.94% <80.00%> (+<0.01%)` | :arrow_up: | |
   | [python](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.99% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.72% <ø> (ø)` | | Carriedforward from [7bb102e](https://app.codecov.io/gh/apache/texera/commit/7bb102e8febbdbdbae116f02537189804bd1b7b6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5066?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org