You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/02 10:06:46 UTC

[GitHub] [couchdb-documentation] asmand opened a new pull request #594: Modify the second query of multi-query example.

asmand opened a new pull request #594:
URL: https://github.com/apache/couchdb-documentation/pull/594


   ## Overview
   
   The second query in the example only included a `skip` and a `limit` parameter. This requires a bit more thinking about the example.
   The purpose of this PR is to make it very clear that the second query is a regular query too. 
   It also tries to make the result set a bit more consistent.
   
   ## Testing recommendations
   
   If the example given could be tested to verify that the output in the example is correct.
   
   ## GitHub issue number
   
   n/a
   
   ## Related Pull Requests
   
   n/a
   
   ## Checklist
   
   n/a


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-documentation] wohali commented on pull request #594: Modify the second query of multi-query example.

Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #594:
URL: https://github.com/apache/couchdb-documentation/pull/594#issuecomment-735990307


   @asmand I... guess? I'm not seeing the point of the change here. Was it not clear to you that the first query was `{"keys":["meatballs","spaghetti"]}` and the second query was `{"limit":3, "skip":2}`?
   
   Why not keep the original request/response and insert a sentence above the example like:
   
   > In the example below, two queries are run with one request. The first searches on the keys `meatballs` and `spaghetti`, while the second only uses a `limit` of 3 and a `skip` of 2.
   
   This would prevent us having to recreate the example to get the sample output 🤣


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-documentation] wohali closed pull request #594: Modify the second query of multi-query example.

Posted by GitBox <gi...@apache.org>.
wohali closed pull request #594:
URL: https://github.com/apache/couchdb-documentation/pull/594


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org