[GitHub] [spark] xkrogen commented on pull request #38712: [WIP][SPARK-41271][SQL] Parameterized SQL queries

[GitBox <gi...@apache.org>]

xkrogen commented on PR #38712:
URL: https://github.com/apache/spark/pull/38712#issuecomment-1334227405

   > Actually, this is just Oracle's proprietary implementation.
   
   I don't think this is true, but admittedly my knowledge of the SQL standardization process is limited, so please correct me if you find gaps in my reasoning. In the [SQL-92 standard](https://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt) (this is the only reference to the full standard I can find with a few minutes of searching; please let me know if you have a better source), `Dynamic SQL` is defined in section 17, and on page 98 it explicitly defines a parameter name as being prefixed by a colon:
   ```
            <parameter name> ::= <colon> <identifier>
   ```
   
   > The `@` marker has been chosen to make migrating from BigQuery to Spark SQL easier.
   
   This seems, to me, like a pretty shaky argument? I could just as easily say that we should choose `:` to make it easier to migrate from Redshift, or, what seems to be a strong argument based on what I found in my last comment, that we should choose positional argument support (`?`) to make it easier to migrate from Trino, PrestoDB, PosgreSQL, Snowflake, _and_ MySQL. Why are we giving BigQuery precedence here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org