You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/02/06 08:38:49 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7149: Added Name in updateProject API and UI

weizhouapache commented on code in PR #7149:
URL: https://github.com/apache/cloudstack/pull/7149#discussion_r1097063093


##########
server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:
##########
@@ -656,7 +656,14 @@ public Project updateProject(final long projectId, final String displayText, fin
         Transaction.execute(new TransactionCallbackWithExceptionNoReturn<ResourceAllocationException>() {
             @Override
             public void doInTransactionWithoutResult(TransactionStatus status) throws ResourceAllocationException {
-                if (displayText != null) {
+                if (displayText != null && name != null) {

Review Comment:
   in line 666, add condition `else if (displayText != null) {`
   
   this part  can be optimized
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org