You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@ws.apache.org by Adam Megacz <ad...@megacz.com> on 2002/07/27 05:39:23 UTC

Apache XML-RPC libs fail to quotify < and & in

The Apache XML-RPC libraries fail to transform '<' into '&lt;' and '&'
into '&amp;' when they occur in a Hashtable key (<name/> element).

This can be fixed by removing this line (XmlRpc.java:756)

    write(nextkey);

And replacing it with this line:

    chardata(nextkey);

  - a

-- 
Sick of HTML user interfaces?
www.xwt.org

Some people don't care if the pie is smaller, so long as they still
get all of it.

Re: Apache XML-RPC libs fail to quotify < and & in

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Adam Megacz <ad...@megacz.com> writes:

> The Apache XML-RPC libraries fail to transform '<' into '&lt;' and '&'
> into '&amp;' when they occur in a Hashtable key (<name/> element).
> 
> This can be fixed by removing this line (XmlRpc.java:756)
> 
>     write(nextkey);
> 
> And replacing it with this line:
> 
>     chardata(nextkey);

Committed to CVS HEAD.  Messages like this should go to the
rpc-dev@xml.apache.org list.  Thanks!

- Dan


Index: XmlWriter.java
===================================================================
RCS file: /home/cvs/xml-rpc/src/java/org/apache/xmlrpc/XmlWriter.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -u -r1.1 -r1.2
--- XmlWriter.java	7 Aug 2002 17:44:36 -0000	1.1
+++ XmlWriter.java	8 Aug 2002 21:31:50 -0000	1.2
@@ -226,13 +226,13 @@
             Hashtable struct = (Hashtable) obj;
             for (Enumeration e = struct.keys(); e.hasMoreElements(); )
             {
-                String nextkey = (String) e.nextElement();
-                Object nextval = struct.get(nextkey);
+                String key = (String) e.nextElement();
+                Object value = struct.get(key);
                 startElement("member");
                 startElement("name");
-                write(nextkey);
+                chardata(key);
                 endElement("name");
-                writeObject(nextval);
+                writeObject(value);
                 endElement("member");
             }
             endElement("struct");

Please commit this bugfix

Posted by Adam Megacz <ad...@megacz.com>.
Could somebody please check this change into CVS?

  - a


Adam Megacz <ad...@megacz.com> writes:
> The Apache XML-RPC libraries fail to transform '<' into '&lt;' and '&'
> into '&amp;' when they occur in a Hashtable key (<name/> element).
> 
> This can be fixed by removing this line (XmlRpc.java:756)
> 
>     write(nextkey);
> 
> And replacing it with this line:
> 
>     chardata(nextkey);
> 
>   - a
> 
> -- 
> Sick of HTML user interfaces?
> www.xwt.org
> 
> Some people don't care if the pie is smaller, so long as they still
> get all of it.
> 

-- 
Sick of HTML user interfaces?
www.xwt.org

Amendment XXVIII: "thou shalt maximize thy stock price at all costs"

Re: Apache XML-RPC libs fail to quotify < and & in

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Adam Megacz <ad...@megacz.com> writes:

> The Apache XML-RPC libraries fail to transform '<' into '&lt;' and '&'
> into '&amp;' when they occur in a Hashtable key (<name/> element).
> 
> This can be fixed by removing this line (XmlRpc.java:756)
> 
>     write(nextkey);
> 
> And replacing it with this line:
> 
>     chardata(nextkey);

Committed to CVS HEAD.  Messages like this should go to the
rpc-dev@xml.apache.org list.  Thanks!

- Dan


Index: XmlWriter.java
===================================================================
RCS file: /home/cvs/xml-rpc/src/java/org/apache/xmlrpc/XmlWriter.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -u -r1.1 -r1.2
--- XmlWriter.java	7 Aug 2002 17:44:36 -0000	1.1
+++ XmlWriter.java	8 Aug 2002 21:31:50 -0000	1.2
@@ -226,13 +226,13 @@
             Hashtable struct = (Hashtable) obj;
             for (Enumeration e = struct.keys(); e.hasMoreElements(); )
             {
-                String nextkey = (String) e.nextElement();
-                Object nextval = struct.get(nextkey);
+                String key = (String) e.nextElement();
+                Object value = struct.get(key);
                 startElement("member");
                 startElement("name");
-                write(nextkey);
+                chardata(key);
                 endElement("name");
-                writeObject(nextval);
+                writeObject(value);
                 endElement("member");
             }
             endElement("struct");

Please commit this bugfix

Posted by Adam Megacz <ad...@megacz.com>.
Could somebody please check this change into CVS?

  - a


Adam Megacz <ad...@megacz.com> writes:
> The Apache XML-RPC libraries fail to transform '<' into '&lt;' and '&'
> into '&amp;' when they occur in a Hashtable key (<name/> element).
> 
> This can be fixed by removing this line (XmlRpc.java:756)
> 
>     write(nextkey);
> 
> And replacing it with this line:
> 
>     chardata(nextkey);
> 
>   - a
> 
> -- 
> Sick of HTML user interfaces?
> www.xwt.org
> 
> Some people don't care if the pie is smaller, so long as they still
> get all of it.
> 

-- 
Sick of HTML user interfaces?
www.xwt.org

Amendment XXVIII: "thou shalt maximize thy stock price at all costs"