You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "shwstppr (via GitHub)" <gi...@apache.org> on 2023/05/10 08:26:45 UTC
[GitHub] [cloudstack-documentation] shwstppr opened a new pull request, #314: vm: note on vmware disk controllers
shwstppr opened a new pull request, #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314
Addresses https://github.com/apache/cloudstack/issues/7004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1209183996
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,15 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ If the rootDiskController and dataDiskController are not specified for an instance using instance details and
+ these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
Review Comment:
I feel then is okay here, https://www.google.com/search?channel=fs&q=then+vs+than
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #314: vm: note on vmware disk controllers
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#issuecomment-1541597715
@rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1209183996
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,15 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ If the rootDiskController and dataDiskController are not specified for an instance using instance details and
+ these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
Review Comment:
I feel `then` is okay here, https://www.google.com/search?channel=fs&q=then+vs+than
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1209183996
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,15 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ If the rootDiskController and dataDiskController are not specified for an instance using instance details and
+ these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
Review Comment:
I feel `then` is okay here, https://www.google.com/search?channel=fs&q=then+vs+than
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1205434158
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,15 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ If the rootDiskController and dataDiskController are not specified for an instance using instance details and
+ these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
Review Comment:
Are you sure @shwstppr ? I am not a native speaker but I think "if - than" and "when - then" are the proper combinations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1201630887
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,10 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ When rootDiskController and dataDiskController are not specified for an instance using instance details and they are set to use osdefault in the template or the global configuration then CloudStack tries to find the recommended disk controllers for it using guest OS from the hypervisor. In some specific cases, it may create issues with the instance deployment or start operation. To overcome this, a specific disk controller can be specified at the instance or template level. For an existing instance its settings can be updated while it is in stopped state by admin.
Review Comment:
this is really two suggestions @shwstppr
1. 'then' -> 'than'
2. refromat to break the line
see what you think of it.
text looks good to me, otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1210447045
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,15 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ If the rootDiskController and dataDiskController are not specified for an instance using instance details and
+ these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
Review Comment:
https://www.google.com/search?channel=fs&client=ubuntu&q=then+vs+than
then seems apt here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland merged pull request #314: vm: note on vmware disk controllers
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #314: vm: note on vmware disk controllers
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#issuecomment-1541598956
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/314. (QA-JID 75)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1201637767
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,10 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ When rootDiskController and dataDiskController are not specified for an instance using instance details and they are set to use osdefault in the template or the global configuration then CloudStack tries to find the recommended disk controllers for it using guest OS from the hypervisor. In some specific cases, it may create issues with the instance deployment or start operation. To overcome this, a specific disk controller can be specified at the instance or template level. For an existing instance its settings can be updated while it is in stopped state by admin.
Review Comment:
forget point 1, i did some more reformulation of that first sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1201651761
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,15 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ If the rootDiskController and dataDiskController are not specified for an instance using instance details and
+ these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
Review Comment:
```suggestion
these are set to use osdefault in the template or the global configuration, then CloudStack tries to find the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1201629174
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,10 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ When rootDiskController and dataDiskController are not specified for an instance using instance details and they are set to use osdefault in the template or the global configuration then CloudStack tries to find the recommended disk controllers for it using guest OS from the hypervisor. In some specific cases, it may create issues with the instance deployment or start operation. To overcome this, a specific disk controller can be specified at the instance or template level. For an existing instance its settings can be updated while it is in stopped state by admin.
Review Comment:
```suggestion
If the rootDiskController and dataDiskController are not specified for an instance using instance details and
these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
recommended disk controllers for it using guest OS from the hypervisor. In some specific cases, it may create
issues with the instance deployment or start operation. To overcome this, a specific disk controller can be
specified at the instance or template level. For an existing instance its settings can be updated while it is in
stopped state by admin.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1201629174
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,10 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ When rootDiskController and dataDiskController are not specified for an instance using instance details and they are set to use osdefault in the template or the global configuration then CloudStack tries to find the recommended disk controllers for it using guest OS from the hypervisor. In some specific cases, it may create issues with the instance deployment or start operation. To overcome this, a specific disk controller can be specified at the instance or template level. For an existing instance its settings can be updated while it is in stopped state by admin.
Review Comment:
```suggestion
When rootDiskController and dataDiskController are not specified for an instance using instance details and
they are set to use osdefault in the template or the global configuration than CloudStack tries to find the
recommended disk controllers for it using guest OS from the hypervisor. In some specific cases, it may create
issues with the instance deployment or start operation. To overcome this, a specific disk controller can be
specified at the instance or template level. For an existing instance its settings can be updated while it is in
stopped state by admin.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #314: vm: note on vmware disk controllers
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#issuecomment-1570294927
> @DaanHoogland are you okay on this?
yes, my english is not good enough to make a call on then vs than in this case and I don´t think people will misunderstand.
I'll merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on pull request #314: vm: note on vmware disk controllers
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#issuecomment-1570268755
@DaanHoogland are you okay on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on a diff in pull request #314: vm: note on vmware disk controllers
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#discussion_r1210447045
##########
source/adminguide/virtual_machines.rst:
##########
@@ -165,6 +165,15 @@ To create a VM from a template:
functions such as mounting additional volumes and ISO images,
live migration, and graceful shutdown.
+ **VMware**
+
+ If the rootDiskController and dataDiskController are not specified for an instance using instance details and
+ these are set to use osdefault in the template or the global configuration, than CloudStack tries to find the
Review Comment:
https://www.google.com/search?channel=fs&client=ubuntu&q=then+vs+than
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud commented on pull request #314: vm: note on vmware disk controllers
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #314:
URL: https://github.com/apache/cloudstack-documentation/pull/314#issuecomment-1541595777
@blueorangutan docbuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org