[GitHub] [helix] rabashizade commented on a change in pull request #1943: Add new metrics to record ZNRecord compression count.

[GitBox <gi...@apache.org>]

rabashizade commented on a change in pull request #1943:
URL: https://github.com/apache/helix/pull/1943#discussion_r794177980



##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/metric/ZkClientMonitor.java
##########
@@ -190,6 +191,12 @@ public void decreaseOutstandingRequestGauge() {
     }
   }
 
+  public void increaseZnodeCompressCounter() {

Review comment:
       With this metric, are we interested in the number of actual compressed ZNodes, or the number of write operations with compressed data? If the latter is the case, then this works, but if we want the total number of ZNodes, I think we should decrease this metric at some point, and on top of that check if the data in existing ZNodes is already compressed, so we don't double-count. I understand this could be costly though. But the naming suggests the metric is returning the number of ZNodes and not the number of compressed writes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org