You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/16 09:30:21 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request, #3211: [MINOR] fix logger number not correct
Shoothzj opened a new pull request, #3211:
URL: https://github.com/apache/bookkeeper/pull/3211
### Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
### Changes
fix logger number not correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a diff in pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#discussion_r854197733
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/datainteg/DataIntegrityCookieValidation.java:
##########
@@ -96,7 +96,7 @@ private void stampCookie(Cookie masterCookie, Version expectedVersion, List<File
log.info("Stamping cookie to directory {}", d);
masterCookie.writeToDirectory(d);
} catch (IOException ioe) {
- log.error("Exception writing cookie to {}", ioe);
+ log.error("Exception writing cookie to ", ioe);
Review Comment:
```suggestion
log.error("Exception writing cookie", ioe);
```
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java:
##########
@@ -151,7 +151,7 @@ && checkAuthPlugin(req.getAuthRequest(), ctx.channel())) {
private boolean checkAuthPlugin(AuthMessage am, final Channel src) {
if (!am.hasAuthPluginName() || !am.getAuthPluginName().equals(authProviderFactory.getPluginName())) {
LOG.error("Received message from incompatible auth plugin. Local = {}," + " Remote = {}, Channel = {}",
Review Comment:
can we remove the concatenation ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#issuecomment-1100772505
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#issuecomment-1104778546
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#issuecomment-1104630969
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap merged pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
zymap merged PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#issuecomment-1105094446
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on a diff in pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#discussion_r854231991
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java:
##########
@@ -151,7 +151,7 @@ && checkAuthPlugin(req.getAuthRequest(), ctx.channel())) {
private boolean checkAuthPlugin(AuthMessage am, final Channel src) {
if (!am.hasAuthPluginName() || !am.getAuthPluginName().equals(authProviderFactory.getPluginName())) {
LOG.error("Received message from incompatible auth plugin. Local = {}," + " Remote = {}, Channel = {}",
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#issuecomment-1100690779
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#issuecomment-1104799103
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3211: [MINOR] fix logger number not correct
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3211:
URL: https://github.com/apache/bookkeeper/pull/3211#issuecomment-1104848028
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org