You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by kc...@apache.org on 2008/06/18 03:08:05 UTC
svn commit: r668954 - in /incubator/thrift/trunk/lib/rb/spec:
binaryprotocol_spec.rb client_spec.rb exception_spec.rb processor_spec.rb
protocol_spec.rb spec_helper.rb
Author: kclark
Date: Tue Jun 17 18:08:05 2008
New Revision: 668954
URL: http://svn.apache.org/viewvc?rev=668954&view=rev
Log:
Rename spec wrapper classes to prevent cross-pollination of specs. Require rspec 1.1.4 or later to fix the "describe Module do" bug
Modified:
incubator/thrift/trunk/lib/rb/spec/binaryprotocol_spec.rb
incubator/thrift/trunk/lib/rb/spec/client_spec.rb
incubator/thrift/trunk/lib/rb/spec/exception_spec.rb
incubator/thrift/trunk/lib/rb/spec/processor_spec.rb
incubator/thrift/trunk/lib/rb/spec/protocol_spec.rb
incubator/thrift/trunk/lib/rb/spec/spec_helper.rb
Modified: incubator/thrift/trunk/lib/rb/spec/binaryprotocol_spec.rb
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/rb/spec/binaryprotocol_spec.rb?rev=668954&r1=668953&r2=668954&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/rb/spec/binaryprotocol_spec.rb (original)
+++ incubator/thrift/trunk/lib/rb/spec/binaryprotocol_spec.rb Tue Jun 17 18:08:05 2008
@@ -1,7 +1,7 @@
require File.dirname(__FILE__) + '/spec_helper'
require 'thrift/protocol/binaryprotocol'
-class ThriftSpec < Spec::ExampleGroup
+class ThriftBinaryProtocolSpec < Spec::ExampleGroup
include Thrift
describe BinaryProtocol do
Modified: incubator/thrift/trunk/lib/rb/spec/client_spec.rb
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/rb/spec/client_spec.rb?rev=668954&r1=668953&r2=668954&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/rb/spec/client_spec.rb (original)
+++ incubator/thrift/trunk/lib/rb/spec/client_spec.rb Tue Jun 17 18:08:05 2008
@@ -1,6 +1,6 @@
require File.dirname(__FILE__) + '/spec_helper'
-class ThriftSpec < Spec::ExampleGroup
+class ThriftClientSpec < Spec::ExampleGroup
include Thrift
class ClientSpec
@@ -12,7 +12,7 @@
@client = ClientSpec.new(@prot)
end
- describe "Client" do
+ describe Client do
it "should re-use iprot for oprot if not otherwise specified" do
@client.instance_variable_get(:'@iprot').should eql(@prot)
@client.instance_variable_get(:'@oprot').should eql(@prot)
Modified: incubator/thrift/trunk/lib/rb/spec/exception_spec.rb
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/rb/spec/exception_spec.rb?rev=668954&r1=668953&r2=668954&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/rb/spec/exception_spec.rb (original)
+++ incubator/thrift/trunk/lib/rb/spec/exception_spec.rb Tue Jun 17 18:08:05 2008
@@ -1,6 +1,6 @@
require File.dirname(__FILE__) + '/spec_helper'
-class ThriftSpec < Spec::ExampleGroup
+class ThriftExceptionSpec < Spec::ExampleGroup
include Thrift
describe Exception do
Modified: incubator/thrift/trunk/lib/rb/spec/processor_spec.rb
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/rb/spec/processor_spec.rb?rev=668954&r1=668953&r2=668954&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/rb/spec/processor_spec.rb (original)
+++ incubator/thrift/trunk/lib/rb/spec/processor_spec.rb Tue Jun 17 18:08:05 2008
@@ -1,6 +1,6 @@
require File.dirname(__FILE__) + '/spec_helper'
-class ThriftSpec < Spec::ExampleGroup
+class ThriftProcessorSpec < Spec::ExampleGroup
include Thrift
class ProcessorSpec
Modified: incubator/thrift/trunk/lib/rb/spec/protocol_spec.rb
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/rb/spec/protocol_spec.rb?rev=668954&r1=668953&r2=668954&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/rb/spec/protocol_spec.rb (original)
+++ incubator/thrift/trunk/lib/rb/spec/protocol_spec.rb Tue Jun 17 18:08:05 2008
@@ -1,6 +1,6 @@
require File.dirname(__FILE__) + '/spec_helper'
-class ThriftSpec < Spec::ExampleGroup
+class ThriftProtocolSpec < Spec::ExampleGroup
include Thrift
before(:each) do
Modified: incubator/thrift/trunk/lib/rb/spec/spec_helper.rb
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/rb/spec/spec_helper.rb?rev=668954&r1=668953&r2=668954&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/rb/spec/spec_helper.rb (original)
+++ incubator/thrift/trunk/lib/rb/spec/spec_helper.rb Tue Jun 17 18:08:05 2008
@@ -1,4 +1,6 @@
require 'rubygems'
+# require at least 1.1.4 to fix a bug with describing Modules
+gem 'rspec', '>= 1.1.4'
require 'spec'
# turn on deprecation so we can test it