You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/14 21:27:16 UTC
[GitHub] [trafficcontrol] jehunte opened a new pull request #4962: fix service category delete bug
jehunte opened a new pull request #4962:
URL: https://github.com/apache/trafficcontrol/pull/4962
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
- [x] This PR fixes #4950
## Which Traffic Control components are affected by this PR?
Traffic Portal
## What is the best way to verify this PR?
Create a Service Category and verify that you can delete it
## If this is a bug fix, what versions of Traffic Control are affected?
Next version to be released
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #4962: fix service category delete bug
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on pull request #4962:
URL: https://github.com/apache/trafficcontrol/pull/4962#issuecomment-674302925
@jehunte - looks good but sorry to do this to you. can you add documentation for the DELETE method of /service_categories. You can follow this example: https://traffic-control-cdn.readthedocs.io/en/latest/api/v3/topologies.html#delete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jehunte commented on pull request #4962: fix service category delete bug
Posted by GitBox <gi...@apache.org>.
jehunte commented on pull request #4962:
URL: https://github.com/apache/trafficcontrol/pull/4962#issuecomment-674953776
@mitchell852 Added documentation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 merged pull request #4962: fix service category delete bug
Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #4962:
URL: https://github.com/apache/trafficcontrol/pull/4962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on pull request #4962: fix service category delete bug
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on pull request #4962:
URL: https://github.com/apache/trafficcontrol/pull/4962#issuecomment-674302925
@jehunte - looks good but sorry to do this to you. can you add documentation for the DELETE method of api/3.0/service_categories. You can follow this example: https://traffic-control-cdn.readthedocs.io/en/latest/api/v3/topologies.html#delete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org