You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "adikou (via GitHub)" <gi...@apache.org> on 2026/08/06 15:06:37 UTC
[PR] KAFKA-20684 [1/N]: Remove test SubscriptionState subscribe overload [kafka]
adikou opened a new pull request, #23102:
URL: https://github.com/apache/kafka/pull/23102
Drops the three subscribe(..., Optional<ConsumerRebalanceListener>) overloads and the listener argument at all 52 call sites, all in clients/src/test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20684 [1/N]: Remove test SubscriptionState subscribe overload [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23102:
URL: https://github.com/apache/kafka/pull/23102#discussion_r3755038010
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java:
##########
@@ -1208,26 +1206,6 @@ public void onPartitionsRevoked(Collection<TopicPartition> partitions) {
assertEquals(List.of("assigned-1arg", "revoked-1arg", "revoked-1arg"), calls);
}
- private static class MockRebalanceListener implements ConsumerRebalanceListener {
Review Comment:
Interesting. This mock listener isn't actually being used :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20684 [1/N]: Remove test SubscriptionState subscribe overload [kafka]
Posted by "adikou (via GitHub)" <gi...@apache.org>.
adikou commented on PR #23102:
URL: https://github.com/apache/kafka/pull/23102#issuecomment-5207647714
cc @chia7712 , @lianetm PRs #23102 - #23109 are final cleanup PRs. I split them up by module to keep them reviewable. PTAL when you can. Hopefully we can get them by 4.4 cut (if it hasn't happened already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20684 [1/N]: Remove test SubscriptionState subscribe overload [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #23102:
URL: https://github.com/apache/kafka/pull/23102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org