[GitHub] [netbeans] KacerCZ commented on a change in pull request #2678: [NETBEANS-5244] Add the project settings for XML configuration of phpDocumentor

[GitBox <gi...@apache.org>]

KacerCZ commented on a change in pull request #2678:
URL: https://github.com/apache/netbeans/pull/2678#discussion_r559167280



##########
File path: php/php.phpdoc/src/org/netbeans/modules/php/phpdoc/PhpDocScript.java
##########
@@ -145,13 +149,24 @@ private String sanitizePath(String path) {
         return path;
     }
 
-    private List<String> getParameters(String sanitizedPhpDocTarget, PhpModule phpModule) {
+    private List<String> getAllParameters(String sanitizedPhpDocTarget, PhpModule phpModule) {
+        List<String> params = new ArrayList<>(getDefaultParameters(sanitizedPhpDocTarget, phpModule));
+        if (PhpDocPreferences.isConfigurationEnabled(phpModule)) {
+            String configurationPath = PhpDocPreferences.getPhpDocConfigurationPath(phpModule);
+            if (!StringUtils.isEmpty(configurationPath)) {
+                params.add(PARAM_CONFIG);
+                params.add(sanitizePath(PhpDocPreferences.getPhpDocConfigurationPath(phpModule)));

Review comment:
       Properties are opened only if target directory for generated documentation is not valid.
   `sanitizePath()` only replaces backslashes on Windows with slashes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists