[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #504: HDDS-2953. Handle replay of S3 requests

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #504: HDDS-2953. Handle replay of S3 requests
URL: https://github.com/apache/hadoop-ozone/pull/504#discussion_r373733885
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3InitiateMultipartUploadRequest.java
 ##########
 @@ -118,6 +127,28 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
 
       validateBucketAndVolume(omMetadataManager, volumeName, bucketName);
 
+      // Check if this transaction is a replay.
+      // We check only the KeyTable here and not the OpenKeyTable. In case
+      // this transaction is a replay but the transaction was not committed
+      // to the KeyTable, then we recreate the key in OpenKey table. This is
+      // okay as all the subsequent transactions would also be replayed and
+      // the openKey table would eventually reach the same state.
+      // The reason we do not check the OpenKey table is to avoid a DB read
+      // in regular non-replay scenario.
+      String dbKeyName = omMetadataManager.getOzoneKey(volumeName, bucketName,
 
 Review comment:
   Looks like checking keyTable is not required here. I feel we can ignore it here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org