You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/04 12:20:20 UTC
[GitHub] [dubbo-go] yakecanlee opened a new pull request #983: Fix: fix client error message #972
yakecanlee opened a new pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
fix client error message
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #972
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #983: Fix: fix client error message #972
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983#discussion_r551306448
##########
File path: remoting/getty/getty_client.go
##########
@@ -38,9 +38,9 @@ import (
)
var (
- errSessionNotExist = perrors.New("session not exist")
- errClientClosed = perrors.New("client closed")
- errClientReadTimeout = perrors.New("client read timeout")
+ errSessionNotExist = perrors.New("session not exist")
+ errClientClosed = perrors.New("client closed")
+ errClientReadTimeoutOrDecoedFail = perrors.New("client read timeout or decode pkg fail")
Review comment:
Decoed？ may be it should be decoded?
##########
File path: remoting/getty/getty_client.go
##########
@@ -38,9 +38,9 @@ import (
)
var (
- errSessionNotExist = perrors.New("session not exist")
- errClientClosed = perrors.New("client closed")
- errClientReadTimeout = perrors.New("client read timeout")
+ errSessionNotExist = perrors.New("session not exist")
+ errClientClosed = perrors.New("client closed")
+ errClientReadTimeoutOrDecoedFail = perrors.New("client read timeout or decode pkg fail")
Review comment:
"client read timeout or decode pkg fail" --> "maybe the client read timeout or fail to decode tcp stream in Writer.Write"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #983: Fix: fix client error message #972
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983#issuecomment-753948999
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=h1) Report
> Merging [#983](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=desc) (f662099) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/9ef971c27814f4978324f7ec819560849e0196e4?el=desc) (9ef971c) will **increase** coverage by `0.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #983 +/- ##
===========================================
+ Coverage 59.59% 59.72% +0.12%
===========================================
Files 261 261
Lines 12930 12930
===========================================
+ Hits 7706 7722 +16
+ Misses 4255 4234 -21
- Partials 969 974 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.05% <0.00%> (-2.95%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.92% <0.00%> (-2.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.00% <0.00%> (+8.88%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `37.60% <0.00%> (+9.60%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=footer). Last update [9ef971c...96a6c30](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #983: Fix: change client error message of issue #972
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #983: Fix: fix client error message #972
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983#issuecomment-753948999
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=h1) Report
> Merging [#983](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=desc) (780a05c) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/9ef971c27814f4978324f7ec819560849e0196e4?el=desc) (9ef971c) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #983 +/- ##
===========================================
+ Coverage 59.59% 59.61% +0.01%
===========================================
Files 261 261
Lines 12930 12930
===========================================
+ Hits 7706 7708 +2
+ Misses 4255 4248 -7
- Partials 969 974 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `74.72% <0.00%> (-4.40%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.05% <0.00%> (-2.95%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `65.36% <0.00%> (-0.87%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `67.36% <0.00%> (+2.10%)` | :arrow_up: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.00% <0.00%> (+8.88%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `89.65% <0.00%> (+10.34%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=footer). Last update [9ef971c...96a6c30](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on pull request #983: Fix: fix client error message #972
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983#issuecomment-753990026
May be errClientReadError is better, because the error.news have the details of error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #983: Fix: fix client error message #972
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983#issuecomment-753948999
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=h1) Report
> Merging [#983](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=desc) (93d7315) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/9ef971c27814f4978324f7ec819560849e0196e4?el=desc) (9ef971c) will **increase** coverage by `0.08%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #983 +/- ##
===========================================
+ Coverage 59.59% 59.68% +0.08%
===========================================
Files 261 261
Lines 12930 12930
===========================================
+ Hits 7706 7717 +11
+ Misses 4255 4244 -11
Partials 969 969
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (ø)` | |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `65.36% <0.00%> (-0.87%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `67.36% <0.00%> (+2.10%)` | :arrow_up: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.00% <0.00%> (+8.88%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `89.65% <0.00%> (+10.34%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=footer). Last update [9ef971c...93d7315](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #983: Fix: fix client error message #972
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #983:
URL: https://github.com/apache/dubbo-go/pull/983#issuecomment-753948999
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=h1) Report
> Merging [#983](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=desc) (96a6c30) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/9ef971c27814f4978324f7ec819560849e0196e4?el=desc) (9ef971c) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #983 +/- ##
===========================================
+ Coverage 59.59% 59.61% +0.01%
===========================================
Files 261 261
Lines 12930 12930
===========================================
+ Hits 7706 7708 +2
+ Misses 4255 4254 -1
+ Partials 969 968 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/983/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (+2.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=footer). Last update [9ef971c...96a6c30](https://codecov.io/gh/apache/dubbo-go/pull/983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org