You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Christian Grobmeier <gr...@gmail.com> on 2011/04/27 16:53:31 UTC
Minor patch (dead code in plaintextresult)
HI,
In PlainTextResult had a bit dead code.
Attached is a small patch which fixes that. It working now, but it
could be more optimal: no need to create inputstreams if the
getResourceAsStream returns null. But this should be the exception
anyway.
Cheers,
Christian
Re: Minor patch (dead code in plaintextresult)
Posted by Maurizio Cucchiara <ma...@gmail.com>.
Patch applied.
Thanks Christian
On 28 April 2011 09:32, Christian Grobmeier <gr...@gmail.com> wrote:
> yap, all done [1]. Thanks for the link
> Cheers
> Christian
>
> [1] https://issues.apache.org/jira/browse/WW-3615
>
>
> On Wed, Apr 27, 2011 at 5:21 PM, Maurizio Cucchiara
> <ma...@gmail.com> wrote:
>> I forgot to send the address https://issues.apache.org/jira/browse/WW
>>
>> On 27 April 2011 17:18, Maurizio Cucchiara <ma...@gmail.com> wrote:
>>> Hi Christian,
>>> could you file an issue on JIRA with the attached patch?
>>> After that I'm pretty sure that someone will take care of applying
>>> your patch (there doesn't seem to be any reason to object)
>>>
>>> On 27 April 2011 16:53, Christian Grobmeier <gr...@gmail.com> wrote:
>>>>
>>>> HI,
>>>>
>>>> In PlainTextResult had a bit dead code.
>>>>
>>>> Attached is a small patch which fixes that. It working now, but it
>>>> could be more optimal: no need to create inputstreams if the
>>>> getResourceAsStream returns null. But this should be the exception
>>>> anyway.
>>>>
>>>> Cheers,
>>>> Christian
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>>> --
>>> Maurizio Cucchiara
>>>
>>
>>
>>
>> --
>> Maurizio Cucchiara
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
>
> --
> http://www.grobmeier.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
Maurizio Cucchiara
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Minor patch (dead code in plaintextresult)
Posted by Christian Grobmeier <gr...@gmail.com>.
yap, all done [1]. Thanks for the link
Cheers
Christian
[1] https://issues.apache.org/jira/browse/WW-3615
On Wed, Apr 27, 2011 at 5:21 PM, Maurizio Cucchiara
<ma...@gmail.com> wrote:
> I forgot to send the address https://issues.apache.org/jira/browse/WW
>
> On 27 April 2011 17:18, Maurizio Cucchiara <ma...@gmail.com> wrote:
>> Hi Christian,
>> could you file an issue on JIRA with the attached patch?
>> After that I'm pretty sure that someone will take care of applying
>> your patch (there doesn't seem to be any reason to object)
>>
>> On 27 April 2011 16:53, Christian Grobmeier <gr...@gmail.com> wrote:
>>>
>>> HI,
>>>
>>> In PlainTextResult had a bit dead code.
>>>
>>> Attached is a small patch which fixes that. It working now, but it
>>> could be more optimal: no need to create inputstreams if the
>>> getResourceAsStream returns null. But this should be the exception
>>> anyway.
>>>
>>> Cheers,
>>> Christian
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>> --
>> Maurizio Cucchiara
>>
>
>
>
> --
> Maurizio Cucchiara
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
http://www.grobmeier.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Minor patch (dead code in plaintextresult)
Posted by Maurizio Cucchiara <ma...@gmail.com>.
I forgot to send the address https://issues.apache.org/jira/browse/WW
On 27 April 2011 17:18, Maurizio Cucchiara <ma...@gmail.com> wrote:
> Hi Christian,
> could you file an issue on JIRA with the attached patch?
> After that I'm pretty sure that someone will take care of applying
> your patch (there doesn't seem to be any reason to object)
>
> On 27 April 2011 16:53, Christian Grobmeier <gr...@gmail.com> wrote:
>>
>> HI,
>>
>> In PlainTextResult had a bit dead code.
>>
>> Attached is a small patch which fixes that. It working now, but it
>> could be more optimal: no need to create inputstreams if the
>> getResourceAsStream returns null. But this should be the exception
>> anyway.
>>
>> Cheers,
>> Christian
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
> --
> Maurizio Cucchiara
>
--
Maurizio Cucchiara
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Minor patch (dead code in plaintextresult)
Posted by Maurizio Cucchiara <ma...@gmail.com>.
Hi Christian,
could you file an issue on JIRA with the attached patch?
After that I'm pretty sure that someone will take care of applying
your patch (there doesn't seem to be any reason to object)
On 27 April 2011 16:53, Christian Grobmeier <gr...@gmail.com> wrote:
>
> HI,
>
> In PlainTextResult had a bit dead code.
>
> Attached is a small patch which fixes that. It working now, but it
> could be more optimal: no need to create inputstreams if the
> getResourceAsStream returns null. But this should be the exception
> anyway.
>
> Cheers,
> Christian
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
--
Maurizio Cucchiara
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org