You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apsaltis <gi...@git.apache.org> on 2016/12/13 17:37:04 UTC
[GitHub] nifi-minifi pull request #65: MINIFI-170 Change FlowStatusReport to be JSON
GitHub user apsaltis opened a pull request:
https://github.com/apache/nifi-minifi/pull/65
MINIFI-170 Change FlowStatusReport to be JSON
The FlowStatus report were in a format that is close to but not JSON.
FlowStatusReport{controllerServiceStatusList=null, processorStatusList=[{name='GenerateFlowFile', processorHealth={runStatus='Running', hasBulletins=false, validationErrorList=[]}, processorStats={activeThreads=0, flowfilesReceived=0, bytesRead=0, bytesWritten=1024000, flowfilesSent=0, invocations=100, processingNanos=106080516}, bulletinList=[]}], connectionStatusList=null, remoteProcessGroupStatusList=null, instanceStatus=null, systemDiagnosticsStatus=null, reportingTaskStatusList=null, errorsGeneratingReport=[]}
This makes it hard to process. The changes in this P/R result in a FlowStatus report that is valid JSON, thus enabling standard tools to be used to process the reports.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apsaltis/nifi-minifi MINIFI-170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 2401547287284a8fd207fdd3bf14e3a76d3ba157
Author: Andrew Psaltis <ps...@gmail.com>
Date: 2016-12-13T17:15:40Z
Changing FlowStatus report to be JSON based
commit c6b27408c525509c7019a1bc63d4b3c94571897f
Author: Andrew Psaltis <ps...@gmail.com>
Date: 2016-12-13T17:32:11Z
cleaning up imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #65: MINIFI-170 Change FlowStatusReport to be JSON
Posted by apsaltis <gi...@git.apache.org>.
Github user apsaltis commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/65#discussion_r92694526
--- Diff: minifi-commons/minifi-utils/pom.xml ---
@@ -15,6 +15,12 @@
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
+ <dependencies>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-databind</artifactId>
--- End diff --
Certainly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #65: MINIFI-170 Change FlowStatusReport to be JSON
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/65#discussion_r92663489
--- Diff: minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/FlowStatusReport.java ---
@@ -111,14 +116,20 @@ public boolean equals(Object o) {
FlowStatusReport that = (FlowStatusReport) o;
- if (getControllerServiceStatusList() != null ? !getControllerServiceStatusList().equals(that.getControllerServiceStatusList()) : that.getControllerServiceStatusList() != null) return false;
--- End diff --
These all appear to be just whitespace changes... could you revert these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #65: MINIFI-170 Change FlowStatusReport to be JSON
Posted by apsaltis <gi...@git.apache.org>.
Github user apsaltis commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/65#discussion_r92694534
--- Diff: minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/FlowStatusReport.java ---
@@ -111,14 +116,20 @@ public boolean equals(Object o) {
FlowStatusReport that = (FlowStatusReport) o;
- if (getControllerServiceStatusList() != null ? !getControllerServiceStatusList().equals(that.getControllerServiceStatusList()) : that.getControllerServiceStatusList() != null) return false;
--- End diff --
certainly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #65: MINIFI-170 Change FlowStatusReport to be JSON
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/65#discussion_r92663391
--- Diff: minifi-commons/minifi-utils/pom.xml ---
@@ -15,6 +15,12 @@
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
+ <dependencies>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-databind</artifactId>
--- End diff --
This can be marked provided. Would it also be possible to put this below this module definition (parent and artifact info)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #65: MINIFI-170 Change FlowStatusReport to be JSON
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---