[GitHub] [hudi] danny0405 commented on a diff in pull request #5445: [HUDI-3953]Flink Hudi module should support low-level source and sink…

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5445:
URL: https://github.com/apache/hudi/pull/5445#discussion_r865567582


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -1217,6 +1234,42 @@ void testBuiltinFunctionWithCatalog(String operation) {
     assertRowsEquals(partitionResult, "[+I[1, 2022-02-02]]");
   }
 
+  @Test
+  public void testSource() throws Exception {
+
+    Configuration conf = TestConfigurations.getDefaultConf(tempFile.getAbsolutePath());
+    conf.setString(FlinkOptions.TABLE_NAME, "t1");
+    conf.setString(FlinkOptions.TABLE_TYPE, "MERGE_ON_READ");
+
+    // write 3 batches of data set
+    TestData.writeData(TestData.dataSetInsert(1, 2), conf);
+    TestData.writeData(TestData.dataSetInsert(3, 4), conf);
+    TestData.writeData(TestData.dataSetInsert(5, 6), conf);
+
+    Map<String, String> options = new HashMap<>();
+    String latestCommit = TestUtils.getLastCompleteInstant(tempFile.getAbsolutePath());
+
+    options.clear();

Review Comment:
   Can this test also be moved to `ITTestDataStreamWrite `?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org