You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2025/01/17 04:46:10 UTC
[PR] Fix pyproject.toml project and license [polaris]
MonkeyCanCode opened a new pull request, #812:
URL: https://github.com/apache/polaris/pull/812
This is fix for https://github.com/apache/polaris/issues/757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pyproject.toml project and license [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1919654342
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
Review Comment:
This is I am not sure, but I can look into later this week.
From official doc, I am not seeing obvious messages for deprecation (nor from running the test locally):
```
Poetry assumes your package contains a package with the same name as project.name located in the root of your project. If this is not the case, populate [tool.poetry.packages](https://python-poetry.org/docs/pyproject/#packages) to specify your packages and their locations.
```
Then looking at pyiceberg, they are doing similar layout as well: https://github.com/apache/iceberg-python/blob/main/pyproject.toml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pyproject.toml project and license [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1919627847
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
Review Comment:
Wonder, I see that this parameter is deprecated in favor of `project.name`. Is it worth to adopt?
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
version = "1.0.0"
description = "Polaris Management Service"
Review Comment:
```suggestion
description = "Apache Polaris Management Service"
```
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
version = "1.0.0"
description = "Polaris Management Service"
-authors = ["OpenAPI Generator Community <te...@openapitools.org>"]
-license = "NoLicense"
+authors = ["Apache Software Foundation <de...@polaris.apache.org>"]
+license = "Apache License 2.0"
readme = "README.md"
-repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"
-keywords = ["OpenAPI", "OpenAPI-Generator", "Polaris Management Service"]
+repository = "https://github.com/apache/polaris/"
+keywords = ["Iceberg", "Polaris Management Service"]
Review Comment:
Maybe add "Polaris" as a separate keyword. Not sure how these keywords actually work and how those are indexed and searched.
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
version = "1.0.0"
description = "Polaris Management Service"
-authors = ["OpenAPI Generator Community <te...@openapitools.org>"]
-license = "NoLicense"
+authors = ["Apache Software Foundation <de...@polaris.apache.org>"]
+license = "Apache License 2.0"
readme = "README.md"
-repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"
-keywords = ["OpenAPI", "OpenAPI-Generator", "Polaris Management Service"]
+repository = "https://github.com/apache/polaris/"
+keywords = ["Iceberg", "Polaris Management Service"]
Review Comment:
Not sure whether "Iceberg" is correct for the client, but I don't mind keeping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pyproject.toml project and license [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1920462473
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
Review Comment:
> But yeah, I can take it up once 2.x is stable (It is out for one month if I recalled)
Fair
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pyproject.toml project and license [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1919651287
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
version = "1.0.0"
description = "Polaris Management Service"
-authors = ["OpenAPI Generator Community <te...@openapitools.org>"]
-license = "NoLicense"
+authors = ["Apache Software Foundation <de...@polaris.apache.org>"]
+license = "Apache License 2.0"
readme = "README.md"
-repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"
-keywords = ["OpenAPI", "OpenAPI-Generator", "Polaris Management Service"]
+repository = "https://github.com/apache/polaris/"
+keywords = ["Iceberg", "Polaris Management Service"]
Review Comment:
Yeah, lets proceed without it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pyproject.toml project and license [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1919676017
##########
regtests/client/python/pyproject.toml:
##########
@@ -20,12 +20,12 @@
[tool.poetry]
name = "polaris"
version = "1.0.0"
-description = "Polaris Management Service"
-authors = ["OpenAPI Generator Community <te...@openapitools.org>"]
-license = "NoLicense"
+description = "Apache Polaris Management Service"
+authors = ["Apache Software Foundation <de...@polaris.apache.org>"]
+license = "Apache License 2.0"
readme = "README.md"
-repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"
-keywords = ["OpenAPI", "OpenAPI-Generator", "Polaris Management Service"]
+repository = "https://github.com/apache/polaris/"
+keywords = ["Polaris", "Polaris Management Service"]
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pyproject.toml project and license [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1919675398
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
Review Comment:
This one says it's deprecated https://python-poetry.org/docs/pyproject/#name - but wait ... deprecated in 2.0. We're good here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pyproject.toml project and license [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1920459672
##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
name = "polaris"
Review Comment:
Good find. Yeah, the current stable release is still 1.8.5. But yeah, I can take it up once 2.x is stable (It is out for one month if I recalled)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org