You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/10 07:41:06 UTC
[GitHub] [dubbo-getty] LaurenceLiZhixin opened a new pull request #75: fix: add read buffer collection option
LaurenceLiZhixin opened a new pull request #75:
URL: https://github.com/apache/dubbo-getty/pull/75
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Create an option to let user define if the session would collect read buffer.
```go
defer func() {
gxbytes.PutBytes(bufp)
if s.readBufferCollectionOpen { // add this option
gxbytes.PutBytesBuffer(pktBuf)
}
}()
```
Consider the case for TCP conn that sometimes pass large data.
If the large Buffer is collected, other TCP conn will be polluted, resulting in large buffers received by other TCP link, and take up a large scale of memeory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks closed pull request #75: fix: add read buffer collection option
Posted by GitBox <gi...@apache.org>.
AlexStocks closed pull request #75:
URL: https://github.com/apache/dubbo-getty/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-commenter commented on pull request #75: fix: add read buffer collection option
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #75:
URL: https://github.com/apache/dubbo-getty/pull/75#issuecomment-916754598
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#75](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb1b367) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/917228c6373bd550818347e564ac89c6cd74696e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (917228c) will **increase** coverage by `0.20%`.
> The diff coverage is `91.30%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 69.14% 69.34% +0.20%
==========================================
Files 8 8
Lines 1426 1442 +16
==========================================
+ Hits 986 1000 +14
- Misses 347 348 +1
- Partials 93 94 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `70.10% <81.81%> (-0.18%)` | :arrow_down: |
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `71.86% <100.00%> (+0.32%)` | :arrow_up: |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b3B0aW9ucy5nbw==) | `83.01% <100.00%> (+2.16%)` | :arrow_up: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `68.23% <100.00%> (+0.34%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [917228c...cb1b367](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-commenter edited a comment on pull request #75: fix: add read buffer collection option
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #75:
URL: https://github.com/apache/dubbo-getty/pull/75#issuecomment-916754598
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#75](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb1b367) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/917228c6373bd550818347e564ac89c6cd74696e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (917228c) will **increase** coverage by `0.20%`.
> The diff coverage is `91.30%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 69.14% 69.34% +0.20%
==========================================
Files 8 8
Lines 1426 1442 +16
==========================================
+ Hits 986 1000 +14
- Misses 347 348 +1
- Partials 93 94 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `70.10% <81.81%> (-0.18%)` | :arrow_down: |
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `71.86% <100.00%> (+0.32%)` | :arrow_up: |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b3B0aW9ucy5nbw==) | `83.01% <100.00%> (+2.16%)` | :arrow_up: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `68.23% <100.00%> (+0.34%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [917228c...cb1b367](https://codecov.io/gh/apache/dubbo-getty/pull/75?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org