[GitHub] [geode] jdeppe-pivotal opened pull request #3152: GEODE-5782: Add some retry logic to retrieving metrics

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

- Because metrics can change between retrievals, we're never guaranteed to be
  able to match exactly. If the upstream code is really broken then this retry
  approach should not hide that.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3152 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3152: GEODE-5782: Add some retry logic to retrieving metrics

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

I thought of that too but couldn't come up with something that was not overly wordy and would have cluttered the code. 

[ Full content available at: https://github.com/apache/geode/pull/3152 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #3152: GEODE-5782: Add some retry logic to retrieving metrics

["kirklund (GitHub)" <gi...@apache.org>]

These assertions might be good candidates to use .as("") to describe the subject of the assertion.

[ Full content available at: https://github.com/apache/geode/pull/3152 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #3152: GEODE-5782: Add some retry logic to retrieving metrics

["demery-pivotal (GitHub)" <gi...@apache.org>]

An example: For line 133 consider something like:
```
.as("total swap space size")
```
It does make the code wordier, but it draws attention to the right code very quickly.

[ Full content available at: https://github.com/apache/geode/pull/3152 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #3152: GEODE-5782: Add some retry logic to retrieving metrics

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/3152 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org