You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2013/11/12 23:36:39 UTC
[Android] Test Dependencies
Hey
I saw a recent commit on the Android repository removing what I left
in the test directory. While I agree that this probably shouldn't
have certain attributes because they're stale, I think that we should
use plugman to install the plugins, because in this case I don't have
my plugins installed in the same directory as Marcel, so the steps
will fail. We can't assume that everyone is using the same setup, and
the last change I did made the tests compatible with Plugman.
Here's the commit that I'm referring to:
https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=b895a0c
Thoughts? Should we bundle Device directly in the repo? What do people think?
Joe
Re: [Android] Test Dependencies
Posted by Marcel Kinard <cm...@gmail.com>.
Done. Thanks for the feedback!
On Nov 13, 2013, at 2:59 PM, Joe Bowser <bo...@gmail.com> wrote:
> Looks fine! Ship it!
Re: [Android] Test Dependencies
Posted by Joe Bowser <bo...@gmail.com>.
Looks fine! Ship it!
On Wed, Nov 13, 2013 at 11:47 AM, Marcel Kinard <cm...@gmail.com> wrote:
> Joe, how does this look?
> https://github.com/cmarcelk/cordova-android/commit/88cb3e8d2ea0bc38a8dfa1eb124e943cc225e335
>
> On Nov 13, 2013, at 1:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> The removal should be just in JS. I'm OK with that.
>
Re: [Android] Test Dependencies
Posted by Marcel Kinard <cm...@gmail.com>.
Joe, how does this look?
https://github.com/cmarcelk/cordova-android/commit/88cb3e8d2ea0bc38a8dfa1eb124e943cc225e335
On Nov 13, 2013, at 1:57 PM, Joe Bowser <bo...@gmail.com> wrote:
> The removal should be just in JS. I'm OK with that.
Re: [Android] Test Dependencies
Posted by Joe Bowser <bo...@gmail.com>.
The removal should be just in JS. I'm OK with that.
On Wed, Nov 13, 2013 at 10:53 AM, Marcel Kinard <cm...@gmail.com> wrote:
> Yes, manually invoking plugman locally to install the device plugin into the test app is a cleaner way of doing that, IMHO. But does that also mean that there should be a number of .gitignore entries in cordova-android/test so that the after-effects of running plugman don't encourage folks to checkin those modifications (the plugin's contents)? That might get messy with some files like cordova-android/test/res/xml/config.xml.
>
> Andrew raises a good question. From what I can tell, the device plugin is used only to populate some human-readable data in the test pages. If that human-readable data isn't really needed, then the device plugin can go away. Joe, would you be OK with that? If so, I can do the removal.
>
> On Nov 12, 2013, at 5:36 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Hey
>>
>> I saw a recent commit on the Android repository removing what I left
>> in the test directory. While I agree that this probably shouldn't
>> have certain attributes because they're stale, I think that we should
>> use plugman to install the plugins, because in this case I don't have
>> my plugins installed in the same directory as Marcel, so the steps
>> will fail. We can't assume that everyone is using the same setup, and
>> the last change I did made the tests compatible with Plugman.
>>
>> Here's the commit that I'm referring to:
>> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=b895a0c
>>
>> Thoughts? Should we bundle Device directly in the repo? What do people think?
>>
>> Joe
>
Re: [Android] Test Dependencies
Posted by Marcel Kinard <cm...@gmail.com>.
Yes, manually invoking plugman locally to install the device plugin into the test app is a cleaner way of doing that, IMHO. But does that also mean that there should be a number of .gitignore entries in cordova-android/test so that the after-effects of running plugman don't encourage folks to checkin those modifications (the plugin's contents)? That might get messy with some files like cordova-android/test/res/xml/config.xml.
Andrew raises a good question. From what I can tell, the device plugin is used only to populate some human-readable data in the test pages. If that human-readable data isn't really needed, then the device plugin can go away. Joe, would you be OK with that? If so, I can do the removal.
On Nov 12, 2013, at 5:36 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I saw a recent commit on the Android repository removing what I left
> in the test directory. While I agree that this probably shouldn't
> have certain attributes because they're stale, I think that we should
> use plugman to install the plugins, because in this case I don't have
> my plugins installed in the same directory as Marcel, so the steps
> will fail. We can't assume that everyone is using the same setup, and
> the last change I did made the tests compatible with Plugman.
>
> Here's the commit that I'm referring to:
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=b895a0c
>
> Thoughts? Should we bundle Device directly in the repo? What do people think?
>
> Joe
Re: [Android] Test Dependencies
Posted by Andrew Grieve <ag...@chromium.org>.
How about we remove the reliance on Device from these tests?
On Tue, Nov 12, 2013 at 5:36 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I saw a recent commit on the Android repository removing what I left
> in the test directory. While I agree that this probably shouldn't
> have certain attributes because they're stale, I think that we should
> use plugman to install the plugins, because in this case I don't have
> my plugins installed in the same directory as Marcel, so the steps
> will fail. We can't assume that everyone is using the same setup, and
> the last change I did made the tests compatible with Plugman.
>
> Here's the commit that I'm referring to:
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=b895a0c
>
> Thoughts? Should we bundle Device directly in the repo? What do people
> think?
>
> Joe
>