You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/17 05:57:37 UTC

[GitHub] [beam] dennisylyung removed a comment on pull request #12583: [BEAM-10706] Fix duplicate key error in DynamoDBIO.Write

dennisylyung removed a comment on pull request #12583:
URL: https://github.com/apache/beam/pull/12583#issuecomment-725986759


   @iemejia I made some changes to use a hashmap for deduplication, and to improve the test. 
   I separated the test for duplicate key, and used mockito to check whether the call to the aws client contains duplicate key. 
   However, as you have worried, each element is put into a single bundle. Hence each bundle consist of one element only, defeating the duplication test.
   I looked at the documentation of `DoFnTester` but it is deprecated. The docs suggests using `TestPipeline` instead, but I couldn't find anyway to control the bundling of elements. 
   Any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org