[GitHub] [accumulo] arvindshmicrosoft commented on a change in pull request #1594: Fix #1588 : Refine rename during minor compaction

[GitBox <gi...@apache.org>]

arvindshmicrosoft commented on a change in pull request #1594:
URL: https://github.com/apache/accumulo/pull/1594#discussion_r414278456



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java
##########
@@ -329,23 +329,34 @@ void bringMinorCompactionOnline(TabletFile tmpDatafile, TabletFile newDatafile,
     StoredTabletFile newFile;
     // rename before putting in metadata table, so files in metadata table should
     // always exist
+    boolean attemptedRename = false;
     do {
       try {
         if (dfv.getNumEntries() == 0) {
+
           tablet.getTabletServer().getFileSystem().deleteRecursively(tmpDatafile.getPath());
-        } else {
-          if (tablet.getTabletServer().getFileSystem().exists(newDatafile.getPath())) {
+        } else // i.e. dfv.getNumEntries() > 0
+        {

Review comment:
       @tushardhadiwal some minor comments:
   * Please modify the placement of this curly brace to match the project's expected style, otherwise the CI fails. The [patch submission steps](https://github.com/apache/accumulo/blob/master/CONTRIBUTING.md#patch-submission) are very useful - ```mvn clean verify -DskipTests``` will usually auto-format code and fix this
   * Related to above - personally I'd also remove the // i.e. dfv.getNumEntries() > 0 comment :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org