You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2025/02/04 17:20:53 UTC

[PR] [SPARK-51082] [SQL] Move all group by alias related tests to group-by-alias.sql [spark]

mihailoale-db opened a new pull request, #49795:
URL: https://github.com/apache/spark/pull/49795

   ### What changes were proposed in this pull request?
   Move all group by alias related tests to `group-by-alias.sql`.
   
   ### Why are the changes needed?
   Better visibility of this specific feature tested.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Added tests.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51082] [SQL] Move all group by alias related tests to group-by-alias.sql [spark]

Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #49795:
URL: https://github.com/apache/spark/pull/49795#issuecomment-2634609907

   @MaxGekk There are some cases in `column-resolution-aggregate.sql` related to group by alias but I feel uncomfortable with deleting them as they are also `column resolution` related. Should we just copy them (without deleting) to the `group-by-alias.sql` as there are not many of them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51082][SQL][TESTS] Move all group by alias related tests to group-by-alias.sql [spark]

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #49795: [SPARK-51082][SQL][TESTS] Move all group by alias related tests to group-by-alias.sql
URL: https://github.com/apache/spark/pull/49795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51082][SQL][TESTS] Move all group by alias related tests to group-by-alias.sql [spark]

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #49795:
URL: https://github.com/apache/spark/pull/49795#issuecomment-2636820705

   +1, LGTM. Merging to master/4.0.
   Thank you, @mihailoale-db and @beliefer for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51082] [SQL] [TESTS] Move all group by alias related tests to group-by-alias.sql [spark]

Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #49795:
URL: https://github.com/apache/spark/pull/49795#issuecomment-2636256617

   > @mihailoale-db Could you add the `[TESTS]` tag to the PR's title, and fix GAs.
   
   Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org