You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/09 05:01:34 UTC

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4209: Optimize MySQL DDLStatement Visitor

tristaZero commented on issue #4209: Optimize MySQL DDLStatement Visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4209#issuecomment-583805183
 
 
   Hi @SteNicholas Thanks for this optimization. It seems this class becomes much better. Your contribution made this class become more clear, not as ugly as ever. Althought more optimization could be done, one point concerns me much is the name of some rules, like `CreateDefinitionClause_`.
   
   Our instruction tells us `CreateDefinitionClause` is standard one, since we visited it in our `Visitor.class`, so i suggest to review any rule name ending with `_` in `MySQLDDLVisitor.java`.
   
   I'd like to see your another PR concerning this. Welcome your opinions. 😃  Good job!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services