[GitHub] [beam] AnandInguva commented on a diff in pull request #22100: Fix missing model_params in Pytorch docstring

[GitBox <gi...@apache.org>]

AnandInguva commented on code in PR #22100:
URL: https://github.com/apache/beam/pull/22100#discussion_r910165121


##########
sdks/python/apache_beam/ml/inference/pytorch_inference.py:
##########
@@ -72,6 +72,8 @@ def __init__(
       state_dict_path: path to the saved dictionary of the model state.
       model_class: class of the Pytorch model that defines the model
         structure.
+      model_params: A dictionary of parameters required to initialize the model

Review Comment:
   ```suggestion
         model_params: A dictionary of arguments required to instantiate the model
   ```



##########
sdks/python/apache_beam/ml/inference/pytorch_inference.py:
##########
@@ -169,10 +171,11 @@ def __init__(
       state_dict_path: path to the saved dictionary of the model state.
       model_class: class of the Pytorch model that defines the model
         structure.
+      model_params: A dictionary of parameters required to initialize the model

Review Comment:
   ```suggestion
         model_params: A dictionary of arguments required to instantiate the model
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org