You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "fishy (via GitHub)" <gi...@apache.org> on 2023/02/15 20:24:15 UTC
[GitHub] [thrift] fishy opened a new pull request, #2759: THRIFT-5685: Revert "THRIFT-5601: Fix forward typedef in go compiler"
fishy opened a new pull request, #2759:
URL: https://github.com/apache/thrift/pull/2759
This reverts commit b39370ec3bc96d201bbc82fbde136f98ae605ed1, and also adds a test case for THRIFT-5685.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2759: THRIFT-5685: Revert "THRIFT-5601: Fix forward typedef in go compiler"
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2759:
URL: https://github.com/apache/thrift/pull/2759#issuecomment-1435533650
Ok great 👍 Going to prepare 0.18.1 in the next days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2759: THRIFT-5685: Revert "THRIFT-5601: Fix forward typedef in go compiler"
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2759:
URL: https://github.com/apache/thrift/pull/2759#issuecomment-1433564935
Anything else besides this patch?
Sent from mobile device.
________________________________
From: fishy ***@***.***>
Sent: Thursday, February 16, 2023 4:12:08 PM
To: apache/thrift ***@***.***>
Cc: Jens Geyer ***@***.***>; Review requested ***@***.***>
Subject: Re: [apache/thrift] THRIFT-5685: Revert "THRIFT-5601: Fix forward typedef in go compiler" (PR #2759)
Merged #2759<https://github.com/apache/thrift/pull/2759> into 0.18.1.
—
Reply to this email directly, view it on GitHub<https://github.com/apache/thrift/pull/2759#event-8538004485>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMQP3LLZVBIYKQYG76WVBDWXY7URANCNFSM6AAAAAAU5JVJQU>.
You are receiving this because your review was requested.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2759: THRIFT-5685: Revert "THRIFT-5601: Fix forward typedef in go compiler"
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2759:
URL: https://github.com/apache/thrift/pull/2759#issuecomment-1433830467
@Jens-G this patch is all. I've run head-to-head test between this version and 0.17.0 and didn't see any significant difference for 2 hours, so we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy merged pull request #2759: THRIFT-5685: Revert "THRIFT-5601: Fix forward typedef in go compiler"
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy merged PR #2759:
URL: https://github.com/apache/thrift/pull/2759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org