[GitHub] huijunw commented on a change in pull request #3136: Nwang/add byte received metric

[GitBox <gi...@apache.org>]

huijunw commented on a change in pull request #3136: Nwang/add byte received metric
URL: https://github.com/apache/incubator-heron/pull/3136#discussion_r244860031
 
 

 ##########
 File path: heron/stmgr/src/cpp/manager/stmgr.cpp
 ##########
 @@ -781,6 +790,9 @@ void StMgr::ProcessAcksAndFails(sp_int32 _src_task_id, sp_int32 _task_id,
 // Called when local tasks generate data
 void StMgr::HandleInstanceData(const sp_int32 _src_task_id, bool _local_spout,
                                proto::system::HeronTupleSet* _message) {
+  instance_bytes_received_metrics_->scope(std::to_string(_src_task_id))
+      ->incr_by(_message->ByteSize());
 
 Review comment:
   is it same as (mutable_data size + mutable_control size)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services