You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ro...@apache.org on 2008/01/31 19:42:22 UTC

svn commit: r617184 - in /httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn: DefaultHttpRoutePlanner.java ProxySelectorRoutePlanner.java

Author: rolandw
Date: Thu Jan 31 10:42:19 2008
New Revision: 617184

URL: http://svn.apache.org/viewvc?rev=617184&view=rev
Log:
attribute visibility and explicit ProxySelector

Modified:
    httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultHttpRoutePlanner.java
    httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/ProxySelectorRoutePlanner.java

Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultHttpRoutePlanner.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultHttpRoutePlanner.java?rev=617184&r1=617183&r2=617184&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultHttpRoutePlanner.java (original)
+++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultHttpRoutePlanner.java Thu Jan 31 10:42:19 2008
@@ -54,8 +54,10 @@
  * nor of system or browser proxy settings.
  */
 public class DefaultHttpRoutePlanner implements HttpRoutePlanner {
-    
-    private ClientConnectionManager connectionManager;
+
+    /** The connection manager, to get at the scheme registry. */
+    protected ClientConnectionManager connectionManager;
+
     
     public DefaultHttpRoutePlanner(ClientConnectionManager aConnManager) {
         setConnectionManager(aConnManager);

Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/ProxySelectorRoutePlanner.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/ProxySelectorRoutePlanner.java?rev=617184&r1=617183&r2=617184&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/ProxySelectorRoutePlanner.java (original)
+++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/ProxySelectorRoutePlanner.java Thu Jan 31 10:42:19 2008
@@ -63,19 +63,45 @@
  */
 public class ProxySelectorRoutePlanner implements HttpRoutePlanner {
     
-    private ClientConnectionManager connectionManager;
+    /** The connection manager, to get at the scheme registry. */
+    protected ClientConnectionManager connectionManager;
+
+    /** The proxy selector to use, or <code>null</code> for system default. */
+    protected ProxySelector proxySelector;
+
     
     public ProxySelectorRoutePlanner(ClientConnectionManager aConnManager) {
         setConnectionManager(aConnManager);
     }
 
 
-    
     public void setConnectionManager(ClientConnectionManager aConnManager) {
         this.connectionManager = aConnManager;
     }
 
 
+    /**
+     * Obtains the proxy selector to use.
+     *
+     * @return the proxy selector, or <code>null</code> for the system default
+     */
+    public ProxySelector getProxySelector() {
+        return this.proxySelector;
+    }
+
+
+    /**
+     * Sets the proxy selector to use.
+     *
+     * @param psel      the proxy selector, or
+     *                  <code>null</code> to use the system default
+     */
+    public void setProxySelector(ProxySelector psel) {
+        this.proxySelector = psel;
+    }
+
+
+
     // non-javadoc, see interface HttpRoutePlanner
     public HttpRoute determineRoute(HttpHost target,
                                     HttpRequest request,
@@ -138,7 +164,9 @@
         throws HttpException {
 
         // the proxy selector can be 'unset', so we better deal with null here
-        final ProxySelector psel = ProxySelector.getDefault();
+        ProxySelector psel = this.proxySelector;
+        if (psel == null)
+            psel = ProxySelector.getDefault();
         if (psel == null)
             return null;