You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2010/11/18 18:32:46 UTC
svn commit: r1036546 - /subversion/trunk/tools/dev/unix-build/Makefile.svn
Author: stsp
Date: Thu Nov 18 17:32:46 2010
New Revision: 1036546
URL: http://svn.apache.org/viewvc?rev=1036546&view=rev
Log:
* tools/dev/unix-build/Makefile.svn: Don't treat failed test runs as fatal.
Makes it easier to run the tests unattended and collect results later.
Modified:
subversion/trunk/tools/dev/unix-build/Makefile.svn
Modified: subversion/trunk/tools/dev/unix-build/Makefile.svn
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dev/unix-build/Makefile.svn?rev=1036546&r1=1036545&r2=1036546&view=diff
==============================================================================
--- subversion/trunk/tools/dev/unix-build/Makefile.svn (original)
+++ subversion/trunk/tools/dev/unix-build/Makefile.svn Thu Nov 18 17:32:46 2010
@@ -1001,11 +1001,11 @@ PARALLEL=PARALLEL=1 CLEANUP=1
svn-check-neon: httpd-conf $(SVN_OBJDIR)/.compiled $(SVN_OBJDIR)/.bindings-compiled
$(HTTPD_START_CMD)
- cd $(svn_builddir) && make check FS_TYPE=fsfs \
+ -cd $(svn_builddir) && make check FS_TYPE=fsfs \
BASE_URL=http://localhost:$(HTTPD_CHECK_PORT) HTTP_LIBRARY=neon \
$(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_neon-fsfs
- cd $(svn_builddir) && make check FS_TYPE=bdb \
+ -cd $(svn_builddir) && make check FS_TYPE=bdb \
BASE_URL=http://localhost:$(HTTPD_CHECK_PORT) HTTP_LIBRARY=neon \
$(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_neon-bdb
@@ -1013,29 +1013,29 @@ svn-check-neon: httpd-conf $(SVN_OBJDIR)
svn-check-serf: httpd-conf $(SVN_OBJDIR)/.compiled $(SVN_OBJDIR)/.bindings-compiled
$(HTTPD_START_CMD)
- cd $(svn_builddir) && make check FS_TYPE=fsfs \
+ -cd $(svn_builddir) && make check FS_TYPE=fsfs \
BASE_URL=http://localhost:$(HTTPD_CHECK_PORT) HTTP_LIBRARY=serf \
$(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_serf-fsfs
- cd $(svn_builddir) && make check FS_TYPE=bdb \
+ -cd $(svn_builddir) && make check FS_TYPE=bdb \
BASE_URL=http://localhost:$(HTTPD_CHECK_PORT) HTTP_LIBRARY=serf \
$(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_serf-bdb
$(HTTPD_STOP_CMD)
svn-check-local:
- cd $(svn_builddir) && make check FS_TYPE=fsfs $(PARALLEL)
+ -cd $(svn_builddir) && make check FS_TYPE=fsfs $(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_local-fsfs
- cd $(svn_builddir) && make check FS_TYPE=bdb $(PARALLEL)
+ -cd $(svn_builddir) && make check FS_TYPE=bdb $(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_local-bdb
svn-check-svn:
$(SVNSERVE_START_CMD)
- cd $(svn_builddir) && make check FS_TYPE=fsfs BASE_URL=svn://127.0.0.1 \
- $(PARALLEL)
+ -cd $(svn_builddir) && make check FS_TYPE=fsfs \
+ BASE_URL=svn://127.0.0.1 $(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_svn-fsfs
- cd $(svn_builddir) && make check FS_TYPE=bdb BASE_URL=svn://127.0.0.1 \
- $(PARALLEL)
+ -cd $(svn_builddir) && make check FS_TYPE=bdb \
+ BASE_URL=svn://127.0.0.1 $(PARALLEL)
ln -f $(svn_builddir)/tests.log $(svn_builddir)/tests.log.ra_svn-bdb
$(SVNSERVE_STOP_CMD)
@@ -1049,18 +1049,18 @@ RUBYLIB=$(SVN_PREFIX)/lib/ruby/site_ruby
grep ^svn_cv_ruby_sitedir_libsuffix $(svn_builddir)/config.log | \
cut -d'=' -f2)
svn-check-swig-pl:
- cd $(svn_builddir) && \
+ -cd $(svn_builddir) && \
env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) make check-swig-pl
svn-check-swig-py:
- cd $(svn_builddir) && \
+ -cd $(svn_builddir) && \
env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) make check-swig-py
svn-check-swig-rb:
- cd $(svn_builddir)/subversion/bindings/swig/ruby/test && \
+ -cd $(svn_builddir)/subversion/bindings/swig/ruby/test && \
env RUBYLIB=$(RUBYLIB) \
LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
ruby run-test.rb --verbose=verbose
svn-check-javahl:
- cd $(svn_builddir) && \
+ -cd $(svn_builddir) && \
env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
make check-javahl
Re: svn commit: r1036546 - /subversion/trunk/tools/dev/unix-build/Makefile.svn
Posted by Blair Zajac <bl...@orcaware.com>.
On 11/18/10 3:36 PM, Stefan Sperling wrote:
> On Thu, Nov 18, 2010 at 02:56:02PM -0800, Blair Zajac wrote:
>> On 11/18/10 9:32 AM, stsp@apache.org wrote:
>>> Author: stsp
>>> Date: Thu Nov 18 17:32:46 2010
>>> New Revision: 1036546
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1036546&view=rev
>>> Log:
>>> * tools/dev/unix-build/Makefile.svn: Don't treat failed test runs as fatal.
>>> Makes it easier to run the tests unattended and collect results later.
>>
>> I'm concerned that this will make it too easy to ignore failures.
>> Say if you have an RPM building script and run the unit tests in the
>> middle of it, which I do.
>>
>> I would want to see a failure.
>>
>> If these targets could fail, but if you have a new target that
>> gathers errors and ignores each subfailure, that would work.
>
> This is not in any way related to the normal Makefile.
>
> It's about the Makefile in tools/dev/unix-build, which I guess noone
> else but me is using. I'm managing it in our repository because it
> might be useful to others.
OK, then ignore what I said :)
Blair
Re: svn commit: r1036546 -
/subversion/trunk/tools/dev/unix-build/Makefile.svn
Posted by Stefan Sperling <st...@apache.org>.
On Thu, Nov 18, 2010 at 02:56:02PM -0800, Blair Zajac wrote:
> On 11/18/10 9:32 AM, stsp@apache.org wrote:
> >Author: stsp
> >Date: Thu Nov 18 17:32:46 2010
> >New Revision: 1036546
> >
> >URL: http://svn.apache.org/viewvc?rev=1036546&view=rev
> >Log:
> >* tools/dev/unix-build/Makefile.svn: Don't treat failed test runs as fatal.
> > Makes it easier to run the tests unattended and collect results later.
>
> I'm concerned that this will make it too easy to ignore failures.
> Say if you have an RPM building script and run the unit tests in the
> middle of it, which I do.
>
> I would want to see a failure.
>
> If these targets could fail, but if you have a new target that
> gathers errors and ignores each subfailure, that would work.
This is not in any way related to the normal Makefile.
It's about the Makefile in tools/dev/unix-build, which I guess noone
else but me is using. I'm managing it in our repository because it
might be useful to others.
Stefan
Re: svn commit: r1036546 - /subversion/trunk/tools/dev/unix-build/Makefile.svn
Posted by Blair Zajac <bl...@orcaware.com>.
On 11/18/10 9:32 AM, stsp@apache.org wrote:
> Author: stsp
> Date: Thu Nov 18 17:32:46 2010
> New Revision: 1036546
>
> URL: http://svn.apache.org/viewvc?rev=1036546&view=rev
> Log:
> * tools/dev/unix-build/Makefile.svn: Don't treat failed test runs as fatal.
> Makes it easier to run the tests unattended and collect results later.
I'm concerned that this will make it too easy to ignore failures. Say if you
have an RPM building script and run the unit tests in the middle of it, which I do.
I would want to see a failure.
If these targets could fail, but if you have a new target that gathers errors
and ignores each subfailure, that would work.
Blair