You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Vincent Massol (JIRA)" <ji...@codehaus.org> on 2006/03/25 18:16:11 UTC
[jira] Created: (MCLOVER-23) Allow custom license to be put in the
repository
Allow custom license to be put in the repository
------------------------------------------------
Key: MCLOVER-23
URL: http://jira.codehaus.org/browse/MCLOVER-23
Project: Maven 2.x Clover Plugin
Type: Task
Versions: 2.0
Reporter: Vincent Massol
It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=all ]
Vincent Massol closed MCLOVER-23:
---------------------------------
Resolution: Fixed
Should be working. Reopen if not.
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "John Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62327 ]
John Allen commented on MCLOVER-23:
-----------------------------------
ps. If each developer wants different configs, say their own checkstyle configs, then you will have to use the standard 'per developer' customisation techniques such as properties and settings.xml, however most coding standards are about trying to ensure a consistent standard across a team and as such tend to mandate a setting/config for such things.
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MCLOVER-23) Allow custom license to be put in the
repository
Posted by "John Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=all ]
John Allen updated MCLOVER-23:
------------------------------
Attachment: clover-license-fix.patch
> Allow custom license to be put in the repository
> ------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=all ]
Vincent Massol updated MCLOVER-23:
----------------------------------
Description: In the same way it's done in the checkstyle and PMD plugins. (was: It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
)
Fix Version: 2.1
Summary: Allow custom license to be passed as JAR resource, URL or File (was: Allow custom license to be put in the repository)
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "John Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62326 ]
John Allen commented on MCLOVER-23:
-----------------------------------
Hi Matthew,
The steps for this are simple and quite convienent: simply create a 'build resources' JAR project that contains your license file as a resource (and as Vincent suggests you might as well put your other build resources and external tool configs in there too), deploy the build resources JAR in the normal manner and then make the JAR a dependency for the clover plugin and reference the path to the license file (as stored in the jar) in the <licenseFile> config. We use the same technique for managing our custom checkstyle and PMD configs and of course the clover license.
ps. What do you mean "you have to modify the root POM to make it work"?
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62104 ]
Matthew Beermann commented on MCLOVER-23:
-----------------------------------------
That approach seems... unpleasant to me. You have to modify the root POM to make it work. What if each developer has different settings? They each must create their own build-tools.jar and install it into their local repo?
Regardless, if this is going to be the recommended approach across a lot of projects, it might merit documentation up at http://maven.apache.org/guides/index.html... but that's a separate issue.
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be put in
the repository
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62084 ]
Vincent Massol commented on MCLOVER-23:
---------------------------------------
Thanks John. It seems we've both been working on it at exactly the same time as I've also just finished implementing it :-)
> Allow custom license to be put in the repository
> ------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62100 ]
Vincent Massol commented on MCLOVER-23:
---------------------------------------
Matthew, plugin configuration files are not placed in the repository. For example take the checkstyle xml config file. This is the same here. The idea is that you create a build-tools jar artifact which contains all your configuration files and that you can put in your local repo. See http://maven.apache.org/plugins/maven-checkstyle-plugin/tips.html.
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MCLOVER-23) Allow custom license to be put in the
repository
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=all ]
Matthew Beermann updated MCLOVER-23:
------------------------------------
Attachment: clover.patch.txt
> Allow custom license to be put in the repository
> ------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Attachments: clover.patch.txt
>
>
> It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be put in
the repository
Posted by "John Allen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_61979 ]
John Allen commented on MCLOVER-23:
-----------------------------------
I completely agree with the principal but think the approach adopted by checkstyle and PMD for custom resource resolution should be adopted:-
A resource (in this case the license file) is specified by a URL which is resolved in a fallback manner covering HTTP, file and classloaders locations. This allows us to simply specify the license file as a file path and include a JAR depdency which contains that file path to the plugin using the standard maven dependency mechanism, the plugin will then locate the resource in the dependency jar.
See checkstyle and PMD for details of this custom resource loader (if memory serves me right its a very simple helper method)
> Allow custom license to be put in the repository
> ------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Attachments: clover.patch.txt
>
>
> It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62101 ]
Vincent Massol commented on MCLOVER-23:
---------------------------------------
Fixed in SVN. It would be nice if someone could validate it works.
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be passed as
JAR resource, URL or File
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62086 ]
Matthew Beermann commented on MCLOVER-23:
-----------------------------------------
At the risk of being dense, with this patch, where exactly in my team's (internal) remote repository would I want to place the license, and with what value for <licensePath/> to make it work?
> Allow custom license to be passed as JAR resource, URL or File
> --------------------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Assignee: Vincent Massol
> Fix For: 2.1
> Attachments: clover-license-fix.patch, clover.patch.txt
>
>
> In the same way it's done in the checkstyle and PMD plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be put in
the repository
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62076 ]
Matthew Beermann commented on MCLOVER-23:
-----------------------------------------
The thing is, the manufacturer of Clover specifies a particular algorithm that will be used to locate the Clover license, and I think we should strive for parity with that. Check the bottom of the page at: http://www.cenqua.com/clover/doc/
> Allow custom license to be put in the repository
> ------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Attachments: clover.patch.txt
>
>
> It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCLOVER-23) Allow custom license to be put in
the repository
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-23?page=comments#action_62079 ]
Vincent Massol commented on MCLOVER-23:
---------------------------------------
Hi Matthew,
Your patch is not quite correct. You're not allowed to put any file in your local repository. This is an area reserved by Maven2 (it was open in Maven1). You have to go through Maven2 to put a file there. Thus the only solution to put a file there is to define a new artifact type. The other reason is that if you're working within a team you'll want to upload this file to your remote repository.
Hi John,
Yes you're right: using the same mechanism is the best solution. This allows putting the license file in a shared JAR. Better and more consistent than what I was proposing.
> Allow custom license to be put in the repository
> ------------------------------------------------
>
> Key: MCLOVER-23
> URL: http://jira.codehaus.org/browse/MCLOVER-23
> Project: Maven 2.x Clover Plugin
> Type: Task
> Versions: 2.0
> Reporter: Vincent Massol
> Attachments: clover.patch.txt
>
>
> It would be nice to share a custom license between different project. A solution is to create a new artifact type and put the license in the local/remote repositories and specify it using a dependency as any other artifact. Idea suggested by Matthew Beermann.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira