You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Stephen Moist <mo...@cloudera.com> on 2018/04/26 16:08:40 UTC
Sentry Release Schedule for FGP and ABAC
Hey all, what does the current roadmap and release schedule look like for FGP and ABAC? I’ve been told that FGP is going out in the next release, ABAC is more slated for the summer. How do we want to handle simultaneous development of these features? For ABAC, our dev process is more agile. So while we have a working version of ABAC right now in review, it’s not the final solution. We plan to iterate, improve, fix and add features to it over the next few months. I had talked with Kalyan and Sergio offline once, they don’t like large patches and recommended not using a feature branch. I don’t see an issue with continuing to develop ABAC and FGP at the same time and committing both to master. We’ll add a switch in ABAC to turn the feature off for now through the next release. What does the community think about supporting development of two different features at once?
Re: Sentry Release Schedule for FGP and ABAC
Posted by Sergio Pena <se...@cloudera.com>.
Hey Stephen,
I'm not totally against having a feature branch, but we had a bad
experience with the Sentry HA re-design where all the work was done in a
feature branch. After doing so many fixes and improvements in that
sentry-ha branch, it was difficult to merge it into master, so we decided
to replace master with the sentry-ha branch causing other fixes to be
missed.
However, ABAC is not a small feature which could deserve a feature branch.
We need to define how a feature branch should work, though, like:
- Rebase often on the feature branch from master. This is to keep up
with latest fixes and avoid code conflicts when attempting to merge the
feature branch to master.
- Avoid merging the feature branch into master as one single commit. If
we can keep the history of commits from the feature branch in master, then
it will help to track issues to specific commits done in master. I've seen
projects where the feature branch disappeared and there was a big commit in
master making difficult the debugging or backport of specific bugfixes
and/or improvements.
- Also be sure your patches specify the branch name so Jenkins do test
the patch against the feature branch.
And once those changes are merged into master, then all JIRAs that specify
the branch name should be changed to have the version number of the master
branch so we can keep track of which version they are part of.
I think that would work for us.
Regarding ABAC, is it clear how we're going to proceed with the feature? I
think we should have a clear vision in the JIRA and/or the Google doc on
how things are going to be integrated with Sentry. That will help us
understand the patches and make sure we have a good integration with the
project.
Sergio
On Thu, Apr 26, 2018 at 12:18 PM, Na Li <li...@cloudera.com> wrote:
> Stephen,
>
> I think it is OK for two features to be developed in parallel at master as
> long as the new updates do not break existing features.
>
> If ABAC feature is not complete when we release sentry 2.1, can you turn
> off ABAC in master branch, so it does not cause the release with incomplete
> feature?
>
> Thanks,
>
> Lina
>
> On Thu, Apr 26, 2018 at 11:08 AM, Stephen Moist <mo...@cloudera.com>
> wrote:
>
> > Hey all, what does the current roadmap and release schedule look like for
> > FGP and ABAC? I’ve been told that FGP is going out in the next release,
> > ABAC is more slated for the summer. How do we want to handle
> simultaneous
> > development of these features? For ABAC, our dev process is more agile.
> > So while we have a working version of ABAC right now in review, it’s not
> > the final solution. We plan to iterate, improve, fix and add features to
> > it over the next few months. I had talked with Kalyan and Sergio offline
> > once, they don’t like large patches and recommended not using a feature
> > branch. I don’t see an issue with continuing to develop ABAC and FGP at
> > the same time and committing both to master. We’ll add a switch in ABAC
> to
> > turn the feature off for now through the next release. What does the
> > community think about supporting development of two different features at
> > once?
>
Re: Sentry Release Schedule for FGP and ABAC
Posted by Na Li <li...@cloudera.com>.
Stephen,
I think it is OK for two features to be developed in parallel at master as
long as the new updates do not break existing features.
If ABAC feature is not complete when we release sentry 2.1, can you turn
off ABAC in master branch, so it does not cause the release with incomplete
feature?
Thanks,
Lina
On Thu, Apr 26, 2018 at 11:08 AM, Stephen Moist <mo...@cloudera.com> wrote:
> Hey all, what does the current roadmap and release schedule look like for
> FGP and ABAC? I’ve been told that FGP is going out in the next release,
> ABAC is more slated for the summer. How do we want to handle simultaneous
> development of these features? For ABAC, our dev process is more agile.
> So while we have a working version of ABAC right now in review, it’s not
> the final solution. We plan to iterate, improve, fix and add features to
> it over the next few months. I had talked with Kalyan and Sergio offline
> once, they don’t like large patches and recommended not using a feature
> branch. I don’t see an issue with continuing to develop ABAC and FGP at
> the same time and committing both to master. We’ll add a switch in ABAC to
> turn the feature off for now through the next release. What does the
> community think about supporting development of two different features at
> once?
Re: Sentry Release Schedule for FGP and ABAC
Posted by Anthony Young-Garner <an...@cloudera.com>.
Yes, force pushes on the feature branch would be required. We can post on
the JIRA that there will be ongoing rebases on the feature branch so anyone
wanting to commit code is aware. And then we can post on the mailing list
when rebases are happening -- either on a regular schedule (e.g. every
other Monday) or as-needed.
On Tue, May 1, 2018 at 11:44 AM, Alexander Kolbasov <ak...@cloudera.com>
wrote:
>
> > On May 1, 2018, at 9:37 AM, Anthony Young-Garner <anthony.young-garner@
> cloudera.com> wrote:
> >
> > If we rebase the feature branch on master on a regular basis does that
> > address the git history concern? I realize we'll need to communicate
> > quickly on the list when there are conflicts.
>
> Would this require regular force pushes on the feature branch? This may be
> destructive for developers who have work in progress, but if they are Ok
> with it it may work.
>
> >
> > On Tue, May 1, 2018 at 11:32 AM, Alexander Kolbasov <ak...@cloudera.com>
> > wrote:
> >
> >> One aspect we should consider is git history - working on feature branch
> >> tends to produce a complicated git tree with many merges instead of the
> >> linear tree that we get by working on master directly.
> >>
> >> On Tue, May 1, 2018 at 8:57 AM, Na Li <li...@cloudera.com> wrote:
> >>
> >>> Steve,
> >>>
> >>> I am OK for ABAC to be on feature branch if you make sure 1) pull
> latest
> >>> master to your feature branch 2) Let us review your changes with all
> unit
> >>> tests pass.
> >>>
> >>> Thanks,
> >>>
> >>> Lina
> >>>
> >>> On Tue, May 1, 2018 at 10:48 AM, Stephen Moist <mo...@cloudera.com>
> >> wrote:
> >>>
> >>>> I’m fine with putting everything into a feature branch for now. Right
> >>>> now, the initial ABAC patch is a working solution. It’s not the final
> >>>> solution that we plan to deliver. We could keep iterating on
> >>> SENTRY-2201 <
> >>>> https://issues.apache.org/jira/browse/SENTRY-2201> and adding more
> >> code
> >>>> to a single patch and merge it back into master. I don’t think anyone
> >> in
> >>>> the community is going to want to review a 10mb patch. So, I think
> >> going
> >>>> forward, we will submit patches to an abac feature branch. We plan to
> >>> keep
> >>>> iterating and expanding on the code base. We want to always have a
> end
> >>> to
> >>>> end working solution at all time that our QA team can test. Once the
> >>>> Sentry community feels that abac is stable, we can merge it into
> >> master.
> >>>> This way it 1) doesn’t impact Sentry 2.1 2) We don’t ship an
> incomplete
> >>>> feature in 2.1 3)We can keep moving forward with development.
> >>>>
> >>>> With that said, I expect then the Sentry community (and more
> >> specifically
> >>>> Committers) to stay on top of the changes we’re making to this feature
> >>>> branch. I don’t want everyone to ignore it for a few months and then
> >>> start
> >>>> re-reveiwing with it as we merge it back into master when we get to
> the
> >>> end.
> >>>>
> >>>> Does this sound good to the community?
> >>>>
> >>>>> On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov <ak...@cloudera.com>
> >>>> wrote:
> >>>>>
> >>>>> Stephen,
> >>>>>
> >>>>> a lot depends on your plans in terms of breaking functionality. For
> >>>>> example, one of the reasons Sentry HA was developed on a feature
> >> branch
> >>>> was
> >>>>> because it was a serious change in architecture and in broke
> >>>> functionality
> >>>>> for a while. I think some of the merge problems which Sergio referred
> >>> to
> >>>>> were caused by poor planning and communication - I think we are in
> >> much
> >>>>> better shape now.
> >>>>>
> >>>>> One thing I would be concerned (in case you do your development in
> >>> master
> >>>>> branch) is that we end up shipping a release with half-baked feature
> >>>> where
> >>>>> there is a bunch of things that are there for the future but not
> >> really
> >>>>> used. If you think this isn't a really a problem, developing on
> >> master
> >>> is
> >>>>> fine since it will automatically handle any potential conflicts with
> >>>>> fine-grained privileges changes.
> >>>>>
> >>>>> Alex
> >>>>>
> >>>>> On Thu, Apr 26, 2018 at 9:08 AM, Stephen Moist <mo...@cloudera.com>
> >>>> wrote:
> >>>>>
> >>>>>> Hey all, what does the current roadmap and release schedule look
> >> like
> >>>> for
> >>>>>> FGP and ABAC? I’ve been told that FGP is going out in the next
> >>> release,
> >>>>>> ABAC is more slated for the summer. How do we want to handle
> >>>> simultaneous
> >>>>>> development of these features? For ABAC, our dev process is more
> >>> agile.
> >>>>>> So while we have a working version of ABAC right now in review, it’s
> >>> not
> >>>>>> the final solution. We plan to iterate, improve, fix and add
> >> features
> >>>> to
> >>>>>> it over the next few months. I had talked with Kalyan and Sergio
> >>>> offline
> >>>>>> once, they don’t like large patches and recommended not using a
> >>> feature
> >>>>>> branch. I don’t see an issue with continuing to develop ABAC and
> >> FGP
> >>> at
> >>>>>> the same time and committing both to master. We’ll add a switch in
> >>>> ABAC to
> >>>>>> turn the feature off for now through the next release. What does
> >> the
> >>>>>> community think about supporting development of two different
> >> features
> >>>> at
> >>>>>> once?
> >>>>
> >>>>
> >>>
> >>
>
>
Re: Sentry Release Schedule for FGP and ABAC
Posted by Alexander Kolbasov <ak...@cloudera.com>.
> On May 1, 2018, at 9:37 AM, Anthony Young-Garner <an...@cloudera.com> wrote:
>
> If we rebase the feature branch on master on a regular basis does that
> address the git history concern? I realize we'll need to communicate
> quickly on the list when there are conflicts.
Would this require regular force pushes on the feature branch? This may be destructive for developers who have work in progress, but if they are Ok with it it may work.
>
> On Tue, May 1, 2018 at 11:32 AM, Alexander Kolbasov <ak...@cloudera.com>
> wrote:
>
>> One aspect we should consider is git history - working on feature branch
>> tends to produce a complicated git tree with many merges instead of the
>> linear tree that we get by working on master directly.
>>
>> On Tue, May 1, 2018 at 8:57 AM, Na Li <li...@cloudera.com> wrote:
>>
>>> Steve,
>>>
>>> I am OK for ABAC to be on feature branch if you make sure 1) pull latest
>>> master to your feature branch 2) Let us review your changes with all unit
>>> tests pass.
>>>
>>> Thanks,
>>>
>>> Lina
>>>
>>> On Tue, May 1, 2018 at 10:48 AM, Stephen Moist <mo...@cloudera.com>
>> wrote:
>>>
>>>> I’m fine with putting everything into a feature branch for now. Right
>>>> now, the initial ABAC patch is a working solution. It’s not the final
>>>> solution that we plan to deliver. We could keep iterating on
>>> SENTRY-2201 <
>>>> https://issues.apache.org/jira/browse/SENTRY-2201> and adding more
>> code
>>>> to a single patch and merge it back into master. I don’t think anyone
>> in
>>>> the community is going to want to review a 10mb patch. So, I think
>> going
>>>> forward, we will submit patches to an abac feature branch. We plan to
>>> keep
>>>> iterating and expanding on the code base. We want to always have a end
>>> to
>>>> end working solution at all time that our QA team can test. Once the
>>>> Sentry community feels that abac is stable, we can merge it into
>> master.
>>>> This way it 1) doesn’t impact Sentry 2.1 2) We don’t ship an incomplete
>>>> feature in 2.1 3)We can keep moving forward with development.
>>>>
>>>> With that said, I expect then the Sentry community (and more
>> specifically
>>>> Committers) to stay on top of the changes we’re making to this feature
>>>> branch. I don’t want everyone to ignore it for a few months and then
>>> start
>>>> re-reveiwing with it as we merge it back into master when we get to the
>>> end.
>>>>
>>>> Does this sound good to the community?
>>>>
>>>>> On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov <ak...@cloudera.com>
>>>> wrote:
>>>>>
>>>>> Stephen,
>>>>>
>>>>> a lot depends on your plans in terms of breaking functionality. For
>>>>> example, one of the reasons Sentry HA was developed on a feature
>> branch
>>>> was
>>>>> because it was a serious change in architecture and in broke
>>>> functionality
>>>>> for a while. I think some of the merge problems which Sergio referred
>>> to
>>>>> were caused by poor planning and communication - I think we are in
>> much
>>>>> better shape now.
>>>>>
>>>>> One thing I would be concerned (in case you do your development in
>>> master
>>>>> branch) is that we end up shipping a release with half-baked feature
>>>> where
>>>>> there is a bunch of things that are there for the future but not
>> really
>>>>> used. If you think this isn't a really a problem, developing on
>> master
>>> is
>>>>> fine since it will automatically handle any potential conflicts with
>>>>> fine-grained privileges changes.
>>>>>
>>>>> Alex
>>>>>
>>>>> On Thu, Apr 26, 2018 at 9:08 AM, Stephen Moist <mo...@cloudera.com>
>>>> wrote:
>>>>>
>>>>>> Hey all, what does the current roadmap and release schedule look
>> like
>>>> for
>>>>>> FGP and ABAC? I’ve been told that FGP is going out in the next
>>> release,
>>>>>> ABAC is more slated for the summer. How do we want to handle
>>>> simultaneous
>>>>>> development of these features? For ABAC, our dev process is more
>>> agile.
>>>>>> So while we have a working version of ABAC right now in review, it’s
>>> not
>>>>>> the final solution. We plan to iterate, improve, fix and add
>> features
>>>> to
>>>>>> it over the next few months. I had talked with Kalyan and Sergio
>>>> offline
>>>>>> once, they don’t like large patches and recommended not using a
>>> feature
>>>>>> branch. I don’t see an issue with continuing to develop ABAC and
>> FGP
>>> at
>>>>>> the same time and committing both to master. We’ll add a switch in
>>>> ABAC to
>>>>>> turn the feature off for now through the next release. What does
>> the
>>>>>> community think about supporting development of two different
>> features
>>>> at
>>>>>> once?
>>>>
>>>>
>>>
>>
Re: Sentry Release Schedule for FGP and ABAC
Posted by Anthony Young-Garner <an...@cloudera.com>.
If we rebase the feature branch on master on a regular basis does that
address the git history concern? I realize we'll need to communicate
quickly on the list when there are conflicts.
On Tue, May 1, 2018 at 11:32 AM, Alexander Kolbasov <ak...@cloudera.com>
wrote:
> One aspect we should consider is git history - working on feature branch
> tends to produce a complicated git tree with many merges instead of the
> linear tree that we get by working on master directly.
>
> On Tue, May 1, 2018 at 8:57 AM, Na Li <li...@cloudera.com> wrote:
>
> > Steve,
> >
> > I am OK for ABAC to be on feature branch if you make sure 1) pull latest
> > master to your feature branch 2) Let us review your changes with all unit
> > tests pass.
> >
> > Thanks,
> >
> > Lina
> >
> > On Tue, May 1, 2018 at 10:48 AM, Stephen Moist <mo...@cloudera.com>
> wrote:
> >
> > > I’m fine with putting everything into a feature branch for now. Right
> > > now, the initial ABAC patch is a working solution. It’s not the final
> > > solution that we plan to deliver. We could keep iterating on
> > SENTRY-2201 <
> > > https://issues.apache.org/jira/browse/SENTRY-2201> and adding more
> code
> > > to a single patch and merge it back into master. I don’t think anyone
> in
> > > the community is going to want to review a 10mb patch. So, I think
> going
> > > forward, we will submit patches to an abac feature branch. We plan to
> > keep
> > > iterating and expanding on the code base. We want to always have a end
> > to
> > > end working solution at all time that our QA team can test. Once the
> > > Sentry community feels that abac is stable, we can merge it into
> master.
> > > This way it 1) doesn’t impact Sentry 2.1 2) We don’t ship an incomplete
> > > feature in 2.1 3)We can keep moving forward with development.
> > >
> > > With that said, I expect then the Sentry community (and more
> specifically
> > > Committers) to stay on top of the changes we’re making to this feature
> > > branch. I don’t want everyone to ignore it for a few months and then
> > start
> > > re-reveiwing with it as we merge it back into master when we get to the
> > end.
> > >
> > > Does this sound good to the community?
> > >
> > > > On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov <ak...@cloudera.com>
> > > wrote:
> > > >
> > > > Stephen,
> > > >
> > > > a lot depends on your plans in terms of breaking functionality. For
> > > > example, one of the reasons Sentry HA was developed on a feature
> branch
> > > was
> > > > because it was a serious change in architecture and in broke
> > > functionality
> > > > for a while. I think some of the merge problems which Sergio referred
> > to
> > > > were caused by poor planning and communication - I think we are in
> much
> > > > better shape now.
> > > >
> > > > One thing I would be concerned (in case you do your development in
> > master
> > > > branch) is that we end up shipping a release with half-baked feature
> > > where
> > > > there is a bunch of things that are there for the future but not
> really
> > > > used. If you think this isn't a really a problem, developing on
> master
> > is
> > > > fine since it will automatically handle any potential conflicts with
> > > > fine-grained privileges changes.
> > > >
> > > > Alex
> > > >
> > > > On Thu, Apr 26, 2018 at 9:08 AM, Stephen Moist <mo...@cloudera.com>
> > > wrote:
> > > >
> > > >> Hey all, what does the current roadmap and release schedule look
> like
> > > for
> > > >> FGP and ABAC? I’ve been told that FGP is going out in the next
> > release,
> > > >> ABAC is more slated for the summer. How do we want to handle
> > > simultaneous
> > > >> development of these features? For ABAC, our dev process is more
> > agile.
> > > >> So while we have a working version of ABAC right now in review, it’s
> > not
> > > >> the final solution. We plan to iterate, improve, fix and add
> features
> > > to
> > > >> it over the next few months. I had talked with Kalyan and Sergio
> > > offline
> > > >> once, they don’t like large patches and recommended not using a
> > feature
> > > >> branch. I don’t see an issue with continuing to develop ABAC and
> FGP
> > at
> > > >> the same time and committing both to master. We’ll add a switch in
> > > ABAC to
> > > >> turn the feature off for now through the next release. What does
> the
> > > >> community think about supporting development of two different
> features
> > > at
> > > >> once?
> > >
> > >
> >
>
Re: Sentry Release Schedule for FGP and ABAC
Posted by Alexander Kolbasov <ak...@cloudera.com>.
One aspect we should consider is git history - working on feature branch
tends to produce a complicated git tree with many merges instead of the
linear tree that we get by working on master directly.
On Tue, May 1, 2018 at 8:57 AM, Na Li <li...@cloudera.com> wrote:
> Steve,
>
> I am OK for ABAC to be on feature branch if you make sure 1) pull latest
> master to your feature branch 2) Let us review your changes with all unit
> tests pass.
>
> Thanks,
>
> Lina
>
> On Tue, May 1, 2018 at 10:48 AM, Stephen Moist <mo...@cloudera.com> wrote:
>
> > I’m fine with putting everything into a feature branch for now. Right
> > now, the initial ABAC patch is a working solution. It’s not the final
> > solution that we plan to deliver. We could keep iterating on
> SENTRY-2201 <
> > https://issues.apache.org/jira/browse/SENTRY-2201> and adding more code
> > to a single patch and merge it back into master. I don’t think anyone in
> > the community is going to want to review a 10mb patch. So, I think going
> > forward, we will submit patches to an abac feature branch. We plan to
> keep
> > iterating and expanding on the code base. We want to always have a end
> to
> > end working solution at all time that our QA team can test. Once the
> > Sentry community feels that abac is stable, we can merge it into master.
> > This way it 1) doesn’t impact Sentry 2.1 2) We don’t ship an incomplete
> > feature in 2.1 3)We can keep moving forward with development.
> >
> > With that said, I expect then the Sentry community (and more specifically
> > Committers) to stay on top of the changes we’re making to this feature
> > branch. I don’t want everyone to ignore it for a few months and then
> start
> > re-reveiwing with it as we merge it back into master when we get to the
> end.
> >
> > Does this sound good to the community?
> >
> > > On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov <ak...@cloudera.com>
> > wrote:
> > >
> > > Stephen,
> > >
> > > a lot depends on your plans in terms of breaking functionality. For
> > > example, one of the reasons Sentry HA was developed on a feature branch
> > was
> > > because it was a serious change in architecture and in broke
> > functionality
> > > for a while. I think some of the merge problems which Sergio referred
> to
> > > were caused by poor planning and communication - I think we are in much
> > > better shape now.
> > >
> > > One thing I would be concerned (in case you do your development in
> master
> > > branch) is that we end up shipping a release with half-baked feature
> > where
> > > there is a bunch of things that are there for the future but not really
> > > used. If you think this isn't a really a problem, developing on master
> is
> > > fine since it will automatically handle any potential conflicts with
> > > fine-grained privileges changes.
> > >
> > > Alex
> > >
> > > On Thu, Apr 26, 2018 at 9:08 AM, Stephen Moist <mo...@cloudera.com>
> > wrote:
> > >
> > >> Hey all, what does the current roadmap and release schedule look like
> > for
> > >> FGP and ABAC? I’ve been told that FGP is going out in the next
> release,
> > >> ABAC is more slated for the summer. How do we want to handle
> > simultaneous
> > >> development of these features? For ABAC, our dev process is more
> agile.
> > >> So while we have a working version of ABAC right now in review, it’s
> not
> > >> the final solution. We plan to iterate, improve, fix and add features
> > to
> > >> it over the next few months. I had talked with Kalyan and Sergio
> > offline
> > >> once, they don’t like large patches and recommended not using a
> feature
> > >> branch. I don’t see an issue with continuing to develop ABAC and FGP
> at
> > >> the same time and committing both to master. We’ll add a switch in
> > ABAC to
> > >> turn the feature off for now through the next release. What does the
> > >> community think about supporting development of two different features
> > at
> > >> once?
> >
> >
>
Re: Sentry Release Schedule for FGP and ABAC
Posted by Na Li <li...@cloudera.com>.
Steve,
I am OK for ABAC to be on feature branch if you make sure 1) pull latest
master to your feature branch 2) Let us review your changes with all unit
tests pass.
Thanks,
Lina
On Tue, May 1, 2018 at 10:48 AM, Stephen Moist <mo...@cloudera.com> wrote:
> I’m fine with putting everything into a feature branch for now. Right
> now, the initial ABAC patch is a working solution. It’s not the final
> solution that we plan to deliver. We could keep iterating on SENTRY-2201 <
> https://issues.apache.org/jira/browse/SENTRY-2201> and adding more code
> to a single patch and merge it back into master. I don’t think anyone in
> the community is going to want to review a 10mb patch. So, I think going
> forward, we will submit patches to an abac feature branch. We plan to keep
> iterating and expanding on the code base. We want to always have a end to
> end working solution at all time that our QA team can test. Once the
> Sentry community feels that abac is stable, we can merge it into master.
> This way it 1) doesn’t impact Sentry 2.1 2) We don’t ship an incomplete
> feature in 2.1 3)We can keep moving forward with development.
>
> With that said, I expect then the Sentry community (and more specifically
> Committers) to stay on top of the changes we’re making to this feature
> branch. I don’t want everyone to ignore it for a few months and then start
> re-reveiwing with it as we merge it back into master when we get to the end.
>
> Does this sound good to the community?
>
> > On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov <ak...@cloudera.com>
> wrote:
> >
> > Stephen,
> >
> > a lot depends on your plans in terms of breaking functionality. For
> > example, one of the reasons Sentry HA was developed on a feature branch
> was
> > because it was a serious change in architecture and in broke
> functionality
> > for a while. I think some of the merge problems which Sergio referred to
> > were caused by poor planning and communication - I think we are in much
> > better shape now.
> >
> > One thing I would be concerned (in case you do your development in master
> > branch) is that we end up shipping a release with half-baked feature
> where
> > there is a bunch of things that are there for the future but not really
> > used. If you think this isn't a really a problem, developing on master is
> > fine since it will automatically handle any potential conflicts with
> > fine-grained privileges changes.
> >
> > Alex
> >
> > On Thu, Apr 26, 2018 at 9:08 AM, Stephen Moist <mo...@cloudera.com>
> wrote:
> >
> >> Hey all, what does the current roadmap and release schedule look like
> for
> >> FGP and ABAC? I’ve been told that FGP is going out in the next release,
> >> ABAC is more slated for the summer. How do we want to handle
> simultaneous
> >> development of these features? For ABAC, our dev process is more agile.
> >> So while we have a working version of ABAC right now in review, it’s not
> >> the final solution. We plan to iterate, improve, fix and add features
> to
> >> it over the next few months. I had talked with Kalyan and Sergio
> offline
> >> once, they don’t like large patches and recommended not using a feature
> >> branch. I don’t see an issue with continuing to develop ABAC and FGP at
> >> the same time and committing both to master. We’ll add a switch in
> ABAC to
> >> turn the feature off for now through the next release. What does the
> >> community think about supporting development of two different features
> at
> >> once?
>
>
Re: Sentry Release Schedule for FGP and ABAC
Posted by Stephen Moist <mo...@cloudera.com>.
I’m fine with putting everything into a feature branch for now. Right now, the initial ABAC patch is a working solution. It’s not the final solution that we plan to deliver. We could keep iterating on SENTRY-2201 <https://issues.apache.org/jira/browse/SENTRY-2201> and adding more code to a single patch and merge it back into master. I don’t think anyone in the community is going to want to review a 10mb patch. So, I think going forward, we will submit patches to an abac feature branch. We plan to keep iterating and expanding on the code base. We want to always have a end to end working solution at all time that our QA team can test. Once the Sentry community feels that abac is stable, we can merge it into master. This way it 1) doesn’t impact Sentry 2.1 2) We don’t ship an incomplete feature in 2.1 3)We can keep moving forward with development.
With that said, I expect then the Sentry community (and more specifically Committers) to stay on top of the changes we’re making to this feature branch. I don’t want everyone to ignore it for a few months and then start re-reveiwing with it as we merge it back into master when we get to the end.
Does this sound good to the community?
> On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov <ak...@cloudera.com> wrote:
>
> Stephen,
>
> a lot depends on your plans in terms of breaking functionality. For
> example, one of the reasons Sentry HA was developed on a feature branch was
> because it was a serious change in architecture and in broke functionality
> for a while. I think some of the merge problems which Sergio referred to
> were caused by poor planning and communication - I think we are in much
> better shape now.
>
> One thing I would be concerned (in case you do your development in master
> branch) is that we end up shipping a release with half-baked feature where
> there is a bunch of things that are there for the future but not really
> used. If you think this isn't a really a problem, developing on master is
> fine since it will automatically handle any potential conflicts with
> fine-grained privileges changes.
>
> Alex
>
> On Thu, Apr 26, 2018 at 9:08 AM, Stephen Moist <mo...@cloudera.com> wrote:
>
>> Hey all, what does the current roadmap and release schedule look like for
>> FGP and ABAC? I’ve been told that FGP is going out in the next release,
>> ABAC is more slated for the summer. How do we want to handle simultaneous
>> development of these features? For ABAC, our dev process is more agile.
>> So while we have a working version of ABAC right now in review, it’s not
>> the final solution. We plan to iterate, improve, fix and add features to
>> it over the next few months. I had talked with Kalyan and Sergio offline
>> once, they don’t like large patches and recommended not using a feature
>> branch. I don’t see an issue with continuing to develop ABAC and FGP at
>> the same time and committing both to master. We’ll add a switch in ABAC to
>> turn the feature off for now through the next release. What does the
>> community think about supporting development of two different features at
>> once?
Re: Sentry Release Schedule for FGP and ABAC
Posted by Alexander Kolbasov <ak...@cloudera.com>.
Stephen,
a lot depends on your plans in terms of breaking functionality. For
example, one of the reasons Sentry HA was developed on a feature branch was
because it was a serious change in architecture and in broke functionality
for a while. I think some of the merge problems which Sergio referred to
were caused by poor planning and communication - I think we are in much
better shape now.
One thing I would be concerned (in case you do your development in master
branch) is that we end up shipping a release with half-baked feature where
there is a bunch of things that are there for the future but not really
used. If you think this isn't a really a problem, developing on master is
fine since it will automatically handle any potential conflicts with
fine-grained privileges changes.
Alex
On Thu, Apr 26, 2018 at 9:08 AM, Stephen Moist <mo...@cloudera.com> wrote:
> Hey all, what does the current roadmap and release schedule look like for
> FGP and ABAC? I’ve been told that FGP is going out in the next release,
> ABAC is more slated for the summer. How do we want to handle simultaneous
> development of these features? For ABAC, our dev process is more agile.
> So while we have a working version of ABAC right now in review, it’s not
> the final solution. We plan to iterate, improve, fix and add features to
> it over the next few months. I had talked with Kalyan and Sergio offline
> once, they don’t like large patches and recommended not using a feature
> branch. I don’t see an issue with continuing to develop ABAC and FGP at
> the same time and committing both to master. We’ll add a switch in ABAC to
> turn the feature off for now through the next release. What does the
> community think about supporting development of two different features at
> once?