You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/05 19:10:22 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #20: rename actor/remote/slf4j/serialization modules
pjfanning opened a new pull request, #20:
URL: https://github.com/apache/incubator-pekko/pull/20
Rename some modules. Aim is to cover other modules like discovery, persistence and streams in a later PR.
Expecting to have to iterate quite a bit even with this number of modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1305963003
@jrudolph I looked at the changes again and don't see anything obviously wrong. When you have time, could you have a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1307077943
current status is that the CI build appears to have a hanging test in pekko-remote
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning closed pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning closed pull request #20: rename actor/remote/slf4j/serialization modules
URL: https://github.com/apache/incubator-pekko/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Claudenw commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
Claudenw commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1311528854
Shouldn't the directory names be changed as part of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] nvollmar commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
nvollmar commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1016193796
##########
akka-stream-tests/src/test/scala/akka/stream/io/TlsSpec.scala:
##########
@@ -564,7 +564,7 @@ class TlsSpec extends StreamSpec(TlsSpec.configOverrides) with WithLogCapturing
Source.single(SendBytes(ByteString.empty)).via(flow).runWith(Sink.ignore)
}
- Await.result(run("akka-remote"), 3.seconds) // CN=akka-remote
+ Await.result(run("pekko-remote"), 3.seconds) // CN=pekko-remote
Review Comment:
Same issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1016348044
##########
akka-stream-tests/src/test/scala/akka/stream/io/TlsSpec.scala:
##########
@@ -564,7 +564,7 @@ class TlsSpec extends StreamSpec(TlsSpec.configOverrides) with WithLogCapturing
Source.single(SendBytes(ByteString.empty)).via(flow).runWith(Sink.ignore)
}
- Await.result(run("akka-remote"), 3.seconds) // CN=akka-remote
+ Await.result(run("pekko-remote"), 3.seconds) // CN=pekko-remote
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
jrudolph commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1015202218
##########
README.md:
##########
@@ -1,4 +1,4 @@
-Akka [](https://index.scala-lang.org/akka/akka/akka-actor)[](https://travis-ci.com/github/akka/akka)
+Akka [](https://index.scala-lang.org/akka/akka/pekko-actor)[](https://travis-ci.com/github/akka/akka)
Review Comment:
A bit weird to fix links half-way...
##########
akka-docs/src/test/java/jdocs/actor/ActorDocTest.java:
##########
@@ -841,7 +841,8 @@ public void usePatternsAskPipe() {
// using timeout from above
CompletableFuture<Object> future2 = ask(actorB, "another request", t).toCompletableFuture();
- CompletableFuture<Result> transformed = future1.thenCombine(future2, (x, s) -> new Result((String) x, (String) s));
+ CompletableFuture<Result> transformed =
Review Comment:
How did these reformats happen?
##########
build.sbt:
##########
@@ -453,30 +453,30 @@ lazy val streamTestsTck = akkaModule("akka-stream-tests-tck")
.enablePlugins(NoPublish)
.disablePlugins(MimaPlugin)
-lazy val testkit = akkaModule("akka-testkit")
+lazy val testkit = pekkoModule("akka-testkit")
.dependsOn(actor)
.settings(Dependencies.testkit)
- .settings(AutomaticModuleName.settings("akka.actor.testkit"))
+ .settings(AutomaticModuleName.settings("pekko.actor.testkit"))
.settings(OSGi.testkit)
.settings(initialCommands += "import akka.testkit._")
-lazy val actorTyped = akkaModule("akka-actor-typed")
+lazy val actorTyped = pekkoModule("pekko-actor-typed")
.dependsOn(actor, slf4j)
- .settings(AutomaticModuleName.settings("akka.actor.typed"))
+ .settings(AutomaticModuleName.settings("pekko.actor.typed"))
.settings(Dependencies.actorTyped)
.settings(OSGi.actorTyped)
.settings(initialCommands :=
"""
- import akka.actor.typed._
- import akka.actor.typed.scaladsl.Behaviors
+ import pekko.actor.typed._
Review Comment:
Was that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1015262511
##########
build.sbt:
##########
@@ -453,30 +453,30 @@ lazy val streamTestsTck = akkaModule("akka-stream-tests-tck")
.enablePlugins(NoPublish)
.disablePlugins(MimaPlugin)
-lazy val testkit = akkaModule("akka-testkit")
+lazy val testkit = pekkoModule("akka-testkit")
.dependsOn(actor)
.settings(Dependencies.testkit)
- .settings(AutomaticModuleName.settings("akka.actor.testkit"))
+ .settings(AutomaticModuleName.settings("pekko.actor.testkit"))
.settings(OSGi.testkit)
.settings(initialCommands += "import akka.testkit._")
-lazy val actorTyped = akkaModule("akka-actor-typed")
+lazy val actorTyped = pekkoModule("pekko-actor-typed")
.dependsOn(actor, slf4j)
- .settings(AutomaticModuleName.settings("akka.actor.typed"))
+ .settings(AutomaticModuleName.settings("pekko.actor.typed"))
.settings(Dependencies.actorTyped)
.settings(OSGi.actorTyped)
.settings(initialCommands :=
"""
- import akka.actor.typed._
- import akka.actor.typed.scaladsl.Behaviors
+ import pekko.actor.typed._
Review Comment:
I reverted this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1311542833
> Shouldn't the directory names be changed as part of this change?
All the akka-actor*/akka-remote*/akka-slf4j*/akka-serialization* dirs are renamed in this PR. Maybe Github doesn't make that obvious.
The vast majority of the files modified in this PR are just modified due to the dir moves - that there are no actual text changes in those files.
I'm avoiding renaming all the dirs in one PR to avoid having super-massive PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1304655631
Thanks @danischroeter
This PR is already quite large and it will take another 2 or 3 just to rename the rest of the modules in this one repo.
The net effect is that when we start publishing jars, they will be called pekko-xyz instead of akka-xyz. We will not be able to continue to call the jars akka-xyz because Lightbend have the trademark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org
[GitHub] [incubator-pekko] nvollmar commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
nvollmar commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1016193558
##########
akka-stream-tests/src/test/scala/akka/stream/io/DeprecatedTlsSpec.scala:
##########
@@ -516,7 +516,7 @@ class DeprecatedTlsSpec extends StreamSpec(DeprecatedTlsSpec.configOverrides) wi
Source.single(SendBytes(ByteString.empty)).via(flow).runWith(Sink.ignore)
}
- Await.result(run("akka-remote"), 3.seconds) // CN=akka-remote
+ Await.result(run("pekko-remote"), 3.seconds) // CN=pekko-remote
Review Comment:
The CN in the trust store is `akka-remote`, probably best to keep it akka-remote for now and open a separate issue to create new keystore/truststore for pekko.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1306900268
@nvollmar I updated the paradox plugin and tried to fix up the akka/pekko renames in akka-docs module. akka-docs now builds for me locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] danischroeter commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
danischroeter commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1304649006
How do we want to tackle the client transition from akka to pekko?
We could start by adding the necessary _client adaptions_ when we perform client relevant changes like this pr?
I fear that if we do not start to track this while _breaking_ the existing clients it will get even harder...
We could add a _AkkaToPekkoMigration.md_ in the root and modify this along with the relevant PR's... wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1015259340
##########
akka-docs/src/test/java/jdocs/actor/ActorDocTest.java:
##########
@@ -841,7 +841,8 @@ public void usePatternsAskPipe() {
// using timeout from above
CompletableFuture<Object> future2 = ask(actorB, "another request", t).toCompletableFuture();
- CompletableFuture<Result> transformed = future1.thenCombine(future2, (x, s) -> new Result((String) x, (String) s));
+ CompletableFuture<Result> transformed =
Review Comment:
I reverted this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1305413468
@jrudolph I made a few changes based on your review - I'll probably need to make more changes later today - and I'll rebase to lower the number of commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1312420144
@jrudolph would you be able to re-review this when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1016347675
##########
akka-stream-tests/src/test/scala/akka/stream/io/DeprecatedTlsSpec.scala:
##########
@@ -516,7 +516,7 @@ class DeprecatedTlsSpec extends StreamSpec(DeprecatedTlsSpec.configOverrides) wi
Source.single(SendBytes(ByteString.empty)).via(flow).runWith(Sink.ignore)
}
- Await.result(run("akka-remote"), 3.seconds) // CN=akka-remote
+ Await.result(run("pekko-remote"), 3.seconds) // CN=pekko-remote
Review Comment:
I've reverted the changes in these 2 tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1309545277
I fixed the broken pekko-remote test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1332490023
this PR is badly affected by the recent package name merge - I will abandon it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] nvollmar commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
nvollmar commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1306678302
@pjfanning The doc generation issue seems related to https://github.com/lightbend/paradox/issues/491
Updating to the latest version of sbt-paradox-akka fixes it:
```
addSbtPlugin("com.lightbend.akka" % "sbt-paradox-akka" % "0.45")
```
We're going to need to create our own version of it to style the documentation.
Fixing this yields a host of doc generation issues due to the rename of modules:
```
Error writing content: project-info.conf does not contain `akka-actor` at /Users/nvo/Development/git/incubator-pekko/akka-docs/src/main/paradox/actors.md
[error] Could not find file for snippet at /Users/nvo/Development/git/incubator-pekko/akka-docs/src/main/paradox/coordinated-shutdown.md:21
[error] : @@snip [reference.conf](/akka-actor/src/main/resources/reference.conf) { #coordinated-shutdown-phases }
[error] ^
[error] Could not find file for snippet at /Users/nvo/Development/git/incubator-pekko/akka-docs/src/main/paradox/event-bus.md:8
[error] : @@snip [EventBus.scala](/akka-actor/src/main/scala/akka/event/EventBus.scala) { #event-bus-api }
[error] ^
[error] Could not find file for snippet at /Users/nvo/Development/git/incubator-pekko/akka-docs/src/main/paradox/general/configuration-reference.md:18
[error] @@snip [reference.conf](/akka-actor/src/main/resources/reference.conf)
[error] ^
[error] Could not find file for snippet at /Users/nvo/Development/git/incubator-pekko/akka-docs/src/main/paradox/general/configuration-reference.md:23
[error] @@snip [reference.conf](/akka-actor-typed/src/main/resources/reference.conf)
[error] ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] danischroeter commented on pull request #20: rename actor/remote/slf4j/serialization modules
Posted by GitBox <gi...@apache.org>.
danischroeter commented on PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#issuecomment-1304657286
> Thanks @danischroeter
>
> This PR is already quite large and it will take another 2 or 3 just to rename the rest of the modules in this one repo.
>
> The net effect is that when we start publishing jars, they will be called pekko-xyz instead of akka-xyz. We will not be able to continue to call the jars akka-xyz because Lightbend have the trademark.
Jep that's all clear and good. Already if we link these _client breaking changes_ to #22 we'll get minimal tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org