You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/15 06:34:25 UTC
[GitHub] [fineract] fynmanoj opened a new pull request #769:
FINERACT-893-fixed-deposit-rollover
fynmanoj opened a new pull request #769: FINERACT-893-fixed-deposit-rollover
URL: https://github.com/apache/fineract/pull/769
## Description
Fixed deposit maturity instructions added. 1 reinvest maturity amount 2. reinvest principal 3. transfer to savings 4, withdraw
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [x] Integration tests have been created/updated for verifying the changes made.
- [x] All Integrations tests are passing with the new commits.
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #769:
FINERACT-893-fixed-deposit-rollover
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #769: FINERACT-893-fixed-deposit-rollover
URL: https://github.com/apache/fineract/pull/769#issuecomment-615893539
@fynmanoj now it failed due to https://issues.apache.org/jira/browse/FINERACT-899 .. can you help fix that one? (In a separate PR I mean, not as part of this.) That would be amazing. Those test failures are really a problem for this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] fynmanoj opened a new pull request #769:
FINERACT-893-fixed-deposit-rollover
Posted by GitBox <gi...@apache.org>.
fynmanoj opened a new pull request #769: FINERACT-893-fixed-deposit-rollover
URL: https://github.com/apache/fineract/pull/769
## Description
Fixed deposit maturity instructions added. 1 reinvest maturity amount 2. reinvest principal 3. transfer to savings 4, withdraw
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [x] Integration tests have been created/updated for verifying the changes made.
- [x] All Integrations tests are passing with the new commits.
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger closed pull request #769:
FINERACT-893-fixed-deposit-rollover
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #769: FINERACT-893-fixed-deposit-rollover
URL: https://github.com/apache/fineract/pull/769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #769:
FINERACT-893-fixed-deposit-rollover
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #769: FINERACT-893-fixed-deposit-rollover
URL: https://github.com/apache/fineract/pull/769#issuecomment-615402657
@fynmanoj Following #764 and #761 this will pass the build (or not at least not fail because of integration tests) if you rebase this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #769:
FINERACT-893-fixed-deposit-rollover
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #769: FINERACT-893-fixed-deposit-rollover
URL: https://github.com/apache/fineract/pull/769#issuecomment-613888332
@fynmanoj re. build failure, please subscribe to and watch (or help fix??) #764 for [FINERACT-852](https://issues.apache.org/jira/browse/FINERACT-852)...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #769:
FINERACT-893-fixed-deposit-rollover
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #769: FINERACT-893-fixed-deposit-rollover
URL: https://github.com/apache/fineract/pull/769#issuecomment-615895947
I just did a quick technical review of this PR, and there is nothing shocking here, and it includes an Integration Test - this would get LGTM from me, once it actually passes the build. - It's a functional Improvement which, ideally, someone with domain expertise should review more. If we don't find anyone interested, I propose we would give this a 2 weeks grace period, and then merge if no one voices any objections....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services