You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/05/08 14:26:45 UTC
[GitHub] [systemds] MKehayov opened a new pull request, #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes
MKehayov opened a new pull request, #1608:
URL: https://github.com/apache/systemds/pull/1608
Implements worker registration in the backend, currently with derby as a local database, but the DB solution can be easily changed, just by implementing the IRepository interface. Once the worker is registered, statistics can be requested, and the FedStatsCollectFunction is used, sending FederatedUDF to the worker. To start the monitoring backend process, a solution similar to the starting of worker nodes is implemented with the "-fedMonitor" flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on PR #1608:
URL: https://github.com/apache/systemds/pull/1608#issuecomment-1126976299
LGTM - thanks for the patch and the fixes @MKehayov. During the merge I only fixed some minor warnings and formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes
URL: https://github.com/apache/systemds/pull/1608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] daphne-eu commented on pull request #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes
Posted by GitBox <gi...@apache.org>.
daphne-eu commented on PR #1608:
URL: https://github.com/apache/systemds/pull/1608#issuecomment-1125274817
Thanks for the patch @MKehayov. As just discussed offline, this looks already good - please double check the fasterxml dependency, tabs vs spaces, exception handling, check of existing schema, use of prepared statements, and a more compact style of assertion checking in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] MKehayov commented on pull request #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes
Posted by GitBox <gi...@apache.org>.
MKehayov commented on PR #1608:
URL: https://github.com/apache/systemds/pull/1608#issuecomment-1126183266
> Thanks for the patch @MKehayov. As just discussed offline, this looks already good - please double check the fasterxml dependency, tabs vs spaces, exception handling, check of existing schema, use of prepared statements, and a more compact style of assertion checking in the tests.
Fasterxml was already used as dependency in /src/main/java/org/apache/sysds/runtime/io/ReaderWriterFederated. I have changed the spaces for tabs, fixed the exception handling, and schema is first checked before being created. I have rewritten the SQL statements in more generic prepared statements and fixed the one-line assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org