[GitHub] [airflow] ashb commented on pull request #29940: Add base OpenLineage provider implementation

["ashb (via GitHub)" <gi...@apache.org>]

ashb commented on PR #29940:
URL: https://github.com/apache/airflow/pull/29940#issuecomment-1499063018

   Lets see if we can sort out the config masking/redacting - possibly by subclassing in someway, something like this:
   
   ```python
   class OLReadactor(SecretsMasker):
       @classmethod
       def from_masker(cls, other: SecretsMasker):
           instance = cls()
           instance.patterns = other.patterns
           instance.replacer = other.replacer
   
       def _redact(self, item: Redactable, name: str | None, depth: int, max_depth: int) -> Redacted:
           # custom type checks here
           return super()._redact(item, name, depth, max_depth)
   
       def _redact_all(self, item: Redactable, depth: int, max_depth: int) -> Redacted:
           # custom type checks here
           return super()._redact_all(item, depth, max_depth)
   ```
   
   (Not sure if you'd need both redact  and redact_all or if just redact would be enough)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org