You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/07/26 10:17:05 UTC
Review Request 68061: Eliminated unnecessary copy in DataEncoder
constructor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68061/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
With C++11, we can rely on move semantics to save one copy
of the to-be-encoded data.
Additionally, removed an unnecessary forward declaration.
Diffs
-----
3rdparty/libprocess/src/encoder.hpp 70b5ec479e90c0eb6ac729b465739b581729a956
Diff: https://reviews.apache.org/r/68061/diff/1/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder
constructor.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68061/
-----------------------------------------------------------
(Updated July 26, 2018, 4:25 p.m.)
Review request for mesos.
Repository: mesos
Description (updated)
-------
With C++11, we can rely on move semantics to save one copy
of the to-be-encoded data.
Additionally this removes an unnecessary forward declaration.
Diffs
-----
3rdparty/libprocess/src/encoder.hpp 963a4fffbc23f431e673fc11d817b8b7c8b22bf3
Diff: https://reviews.apache.org/r/68061/diff/2/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder
constructor.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68061/
-----------------------------------------------------------
(Updated July 26, 2018, 4:24 p.m.)
Review request for mesos.
Changes
-------
Rebased onto latest master.
Repository: mesos
Description (updated)
-------
With C++11, we can rely on move semantics to save one copy
of the to-be-encoded data.
Diffs (updated)
-----
3rdparty/libprocess/src/encoder.hpp 963a4fffbc23f431e673fc11d817b8b7c8b22bf3
Diff: https://reviews.apache.org/r/68061/diff/2/
Changes: https://reviews.apache.org/r/68061/diff/1-2/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder
constructor.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68061/#review206507
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On July 26, 2018, 10:17 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68061/
> -----------------------------------------------------------
>
> (Updated July 26, 2018, 10:17 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With C++11, we can rely on move semantics to save one copy
> of the to-be-encoded data.
>
> Additionally, removed an unnecessary forward declaration.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 70b5ec479e90c0eb6ac729b465739b581729a956
>
>
> Diff: https://reviews.apache.org/r/68061/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder
constructor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68061/#review206497
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68061`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1986/mesos-review-68061
Relevant logs:
- [apply-review-68061-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1986/mesos-review-68061/logs/apply-review-68061-stdout.log):
```
error: patch failed: 3rdparty/libprocess/src/encoder.hpp:65
error: 3rdparty/libprocess/src/encoder.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On July 26, 2018, 10:17 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68061/
> -----------------------------------------------------------
>
> (Updated July 26, 2018, 10:17 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With C++11, we can rely on move semantics to save one copy
> of the to-be-encoded data.
>
> Additionally, removed an unnecessary forward declaration.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/encoder.hpp 70b5ec479e90c0eb6ac729b465739b581729a956
>
>
> Diff: https://reviews.apache.org/r/68061/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>