You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/08/27 02:33:01 UTC
[jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
This ensures that we have solely internal-only callers such as
clearContainer.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds remove-get-async-blobstore
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/126
-- Commit Summary --
* Remove BlobStoreContext.getAsyncBlobStore
-- File Changes --
M apis/s3/src/main/java/org/jclouds/s3/blobstore/S3BlobStoreContext.java (3)
M apis/s3/src/main/java/org/jclouds/s3/blobstore/internal/S3BlobStoreContextImpl.java (6)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/SwiftAsyncBlobStore.java (4)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/SwiftBlobStore.java (4)
M blobstore/src/main/java/org/jclouds/blobstore/BlobStoreContext.java (10)
M blobstore/src/main/java/org/jclouds/blobstore/internal/BlobStoreContextImpl.java (5)
M blobstore/src/main/java/org/jclouds/blobstore/util/BlobStoreUtils.java (10)
M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java (8)
M blobstore/src/test/java/org/jclouds/blobstore/util/BlobStoreUtilsTest.java (32)
M providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/AWSS3BlobStoreContext.java (3)
M providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/internal/AWSS3BlobStoreContextImpl.java (6)
M providers/aws-s3/src/test/java/org/jclouds/aws/s3/AWSS3ClientLiveTest.java (8)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/126.patch
https://github.com/jclouds/jclouds/pull/126.diff
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Andrew Gaul <no...@github.com>.
Closed #126.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#event-125336038
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Andrew Gaul <no...@github.com>.
Deasync requires more thought.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#issuecomment-44345069
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Everett Toews <no...@github.com>.
During release week we like to do a little house cleaning in the jclouds world. That means sweeping out the pull request queue.
This PR is over 6 months old. Please update us on its status here. If we don't hear anything, we will take that as lazy consensus that the PR is no longer relevant and it will be closed on Friday, May 30.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#issuecomment-44345018
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Andrew Phillips <no...@github.com>.
@andrewgaul: rebase? Just wondering if this, as a breaking change, would be something for 1.7.0 or 2.0?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#issuecomment-30171552
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #346 FAILURE
That one looks unrelated:
```
stderr: fatal: read error: Connection reset by peer
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#issuecomment-24071853
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #173](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/173/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#issuecomment-23307557
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #346](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/346/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#issuecomment-23307586
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Andrew Phillips <no...@github.com>.
> checkNotNull(container, "container");
>
> String name = blobName.apply(blob);
> if (name.indexOf('/') > 0) {
> - return asyncBlobStore.createDirectory(container, parseDirectoryFromPath(name));
> - } else {
> - return Futures.immediateFuture(null);
> + blobStore.createDirectory(container, parseDirectoryFromPath(name));
Missing a `return` here? Sorry, not checked the remainder of the code ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126/files#r6236910
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Andrew Phillips <no...@github.com>.
> String container = "container";
> Blob blob = createMock(Blob.class);
> MutableBlobMetadata md = createMock(MutableBlobMetadata.class);
>
> expect(blob.getMetadata()).andReturn(md).atLeastOnce();
> expect(md.getName()).andReturn("rootpath/subpath/hello").atLeastOnce();
> - expect(asyncBlobStore.createDirectory("container", "rootpath/subpath")).andReturn(null);
> + blobStore.createDirectory("container", "rootpath/subpath");
`expect` here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126/files#r6236942
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by Andrew Phillips <no...@github.com>.
> String container = "container";
> Blob blob = createMock(Blob.class);
> MutableBlobMetadata md = createMock(MutableBlobMetadata.class);
>
> expect(blob.getMetadata()).andReturn(md).atLeastOnce();
> expect(md.getName()).andReturn("rootpath/hello").atLeastOnce();
> - expect(asyncBlobStore.createDirectory("container", "rootpath")).andReturn(null);
> + blobStore.createDirectory("container", "rootpath");
Add an `expect` here too?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126/files#r6236933
Re: [jclouds] Remove BlobStoreContext.getAsyncBlobStore (#126)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #633](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/633/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/126#issuecomment-23307550