You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashb (via GitHub)" <gi...@apache.org> on 2025/04/16 10:50:56 UTC
[PR] Don't spend time adding `ti.try_id` only to remove it in a later migration [airflow]
ashb opened a new pull request, #49346:
URL: https://github.com/apache/airflow/pull/49346
There's no point expensively generating and adding a UUID for each of
(possibly millions) of TI rows, to then go and drop that column a few
migrations later, all within the 3.0 release upgrade.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't spend time adding `ti.try_id` only to remove it in a later migration [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #49346:
URL: https://github.com/apache/airflow/pull/49346#issuecomment-2809294197
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't spend time adding `ti.try_id` only to remove it in a later migration [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #49346:
URL: https://github.com/apache/airflow/pull/49346#issuecomment-2809276111
@vatsrahul1001 A second pair of eyes would be good, yes please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't spend time adding `ti.try_id` only to remove it in a later migration [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #49346:
URL: https://github.com/apache/airflow/pull/49346#issuecomment-2809264914
> I haven't yet tested this with data in the upgrade, I want to get it up for CI and reviews while I do that.
@ashb do let me know if you need help testing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't spend time adding `ti.try_id` only to remove it in a later migration [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #49346:
URL: https://github.com/apache/airflow/pull/49346#issuecomment-2809200404
I haven't yet tested this with data in the upgrade, I want to get it up for CI and reviews while I do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't spend time adding `ti.try_id` only to remove it in a later migration [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #49346:
URL: https://github.com/apache/airflow/pull/49346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org