[GitHub] [ozone] Galsza commented on a diff in pull request #4317: HDDS-8030. Cleanup unused/unnecessary code related to CertificateClient

["Galsza (via GitHub)" <gi...@apache.org>]

Galsza commented on code in PR #4317:
URL: https://github.com/apache/ozone/pull/4317#discussion_r1118946311


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/utils/CertificateSignRequest.java:
##########
@@ -94,10 +98,47 @@ private CertificateSignRequest(String subject, String scmID, String clusterID,
     this.extensions = extensions;
   }
 
+  public static String getDistinguishedNameFormat() {
+    return DISTINGUISHED_NAME_FORMAT;
+  }
+
+  public static X500Name getDistinguishedName(String subject, String scmID,
+      String clusterID) {
+    return new X500Name(String.format(getDistinguishedNameFormat(), subject,
+        scmID, clusterID));
+  }
+
+  // TODO: move the PKCS10CSRValidator class

Review Comment:
   This TODO comment is left in. Could you resolve it/create a Jira where it's going to be fixed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org