You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/26 18:06:09 UTC
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #4657: [WIP] API/Core: View support
amogh-jahagirdar commented on code in PR #4657:
URL: https://github.com/apache/iceberg/pull/4657#discussion_r882935821
##########
api/src/main/java/org/apache/iceberg/view/ViewUpdateProperties.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.view;
+
+import java.util.Map;
+import org.apache.iceberg.PendingUpdate;
+
+/**
+ * API for updating view properties.
+ * <p>
+ * Apply returns the updated view properties as a map for validation.
+ * <p>
+ * When committing, these changes will be applied to the current view metadata.
+ * Commit conflicts will be resolved by applying the pending changes to the new view metadata.
+ */
+public interface ViewUpdateProperties extends PendingUpdate<Map<String, String>> {
+
+ /**
+ * Add a key/value property to the view.
+ *
+ * @param key a String key
+ * @param value a String value
+ * @return this for method chaining
+ * @throws NullPointerException If either the key or value is null
Review Comment:
I think the standard is generally IllegalArgumentException if either the key or value is null.
##########
api/src/main/java/org/apache/iceberg/view/ViewVersion.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.view;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * A version of the view at a point in time.
+ * <p>
+ * A version consists of a view metadata file.
+ * <p>
+ * Versions are created by view operations, like Create and Replace.
+ */
+public interface ViewVersion {
+ /**
+ * Return this version's ID.
+ *
+ * @return a long ID
+ */
+ int versionId();
+
+ /**
+ * Return this version's parent ID or null.
+ *
+ * @return a long ID for this version's parent, or null if it has no parent
+ */
+ Integer parentId();
Review Comment:
Should this be Long?
##########
api/src/main/java/org/apache/iceberg/view/ViewVersion.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.view;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * A version of the view at a point in time.
+ * <p>
+ * A version consists of a view metadata file.
+ * <p>
+ * Versions are created by view operations, like Create and Replace.
+ */
+public interface ViewVersion {
+ /**
+ * Return this version's ID.
+ *
+ * @return a long ID
+ */
+ int versionId();
Review Comment:
Should this be a long?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org