You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "victorgkang (via GitHub)" <gi...@apache.org> on 2024/04/07 07:40:40 UTC

[PR] update consoleNamesvrAddr if namesvrAddr changed [rocketmq-operator]

victorgkang opened a new pull request, #223:
URL: https://github.com/apache/rocketmq-operator/pull/223

   ## What is the purpose of the change
   
   If size of nameservice changed, the deployment of console should change namesrv addr.
   
   ## Brief changelog
   
   update consoleNamesvrAddr if namesvrAddr changed
   
   ## Verifying this change
   
   change size of namservice, and you should find pod of console will restart, and the namesvr addr changed.
   
   **Please go through this checklist to help us incorporate your contribution quickly and easily.**
   
   Notice: `It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR`.
   
   - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq-operator/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check RBAC rights for Kubernetes roles.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. 
   - [ ] Run `make docker-build` to build docker image for operator, try your changes from Pod inside your Kubernetes cluster, **not just locally**. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes. 
   - [ ] Before committing your changes, remember to run `make manifests` to make sure the CRD files are updated. 
   - [ ] Update documentation if necessary.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] update consoleNamesvrAddr if nameservice changed [rocketmq-operator]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #223:
URL: https://github.com/apache/rocketmq-operator/pull/223#issuecomment-5129770263

   ⚠️ **Merge conflict detected**
   
   This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
   
   ```bash
   git fetch origin
   git checkout upate-console-namesvr
   git rebase origin/main
   # resolve conflicts, then:
   git push --force-with-lease
   ```
   
   This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
   
   ---
   *Automated notification by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org